From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Leo Yan <leo.yan@linaro.org>
Cc: peterz@infradead.org, Mark Rutland <mark.rutland@arm.com>,
Ingo Molnar <mingo@redhat.com>, Wei Li <liwei391@huawei.com>,
Al Grant <al.grant@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
"Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com>,
Nick Desaulniers <ndesaulniers@google.com>,
Kemeng Shi <shikemeng@huawei.com>,
Ian Rogers <irogers@google.com>,
John Garry <john.garry@huawei.com>,
Stephane Eranian <eranian@google.com>,
Nick Gasson <nick.gasson@arm.com>,
Andi Kleen <ak@linux.intel.com>,
Steve MacLean <Steve.MacLean@microsoft.com>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
Kan Liang <kan.liang@linux.intel.com>,
Will Deacon <will@kernel.org>, James Clark <james.clark@arm.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/6] perf tsc: Add rdtsc() for Arm64
Date: Fri, 4 Sep 2020 16:08:26 -0300 [thread overview]
Message-ID: <20200904190826.GC3753976@kernel.org> (raw)
In-Reply-To: <20200903022354.GA1583@leoy-ThinkPad-X240s>
Em Thu, Sep 03, 2020 at 10:23:54AM +0800, Leo Yan escreveu:
> Hi Peter,
>
> On Wed, Sep 02, 2020 at 03:48:05PM +0200, Peter Zijlstra wrote:
> > On Wed, Sep 02, 2020 at 02:21:27PM +0100, Leo Yan wrote:
> > > The system register CNTVCT_EL0 can be used to retrieve the counter from
> > > user space. Add rdtsc() for Arm64.
> >
> > > +u64 rdtsc(void)
> > > +{
> > > + u64 val;
> >
> > Would it make sense to put a comment in that this counter is/could-be
> > 'short' ? Because unlike x86-TSC, this thing isn't architecturally
> > specified to be 64bits wide.
>
> Will add below comments:
>
> According to ARM DDI 0487F.c, from Armv8.0 to Armv8.5 inclusive, the
> system counter is at least 56 bits wide; from Armv8.6, the counter must
> be 64 bits wide. So the system counter could be less than 64 bits wide
> and it is attributed with the flag 'cap_user_time_short' is true.
Ok, so waiting for v4.
- Arnaldo
next prev parent reply other threads:[~2020-09-04 19:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-02 13:21 [PATCH v3 0/6] Perf tool: Support TSC for Arm64 Leo Yan
2020-09-02 13:21 ` [PATCH v3 1/6] perf tsc: Move out common functions from x86 Leo Yan
2020-09-02 13:21 ` [PATCH v3 2/6] perf tsc: Add rdtsc() for Arm64 Leo Yan
2020-09-02 13:48 ` peterz
2020-09-03 2:23 ` Leo Yan
2020-09-04 19:08 ` Arnaldo Carvalho de Melo [this message]
2020-09-02 13:21 ` [PATCH v3 3/6] perf tsc: Calculate timestamp with cap_user_time_short Leo Yan
2020-09-02 13:21 ` [PATCH v3 4/6] perf tsc: Support cap_user_time_short for event TIME_CONV Leo Yan
2020-09-02 13:21 ` [PATCH v3 5/6] perf tests tsc: Make tsc testing as a common testing Leo Yan
2020-09-02 13:21 ` [PATCH v3 6/6] perf tests tsc: Add checking helper is_supported() Leo Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200904190826.GC3753976@kernel.org \
--to=acme@kernel.org \
--cc=Steve.MacLean@microsoft.com \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=al.grant@arm.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=eranian@google.com \
--cc=gustavoars@kernel.org \
--cc=irogers@google.com \
--cc=james.clark@arm.com \
--cc=john.garry@huawei.com \
--cc=jolsa@redhat.com \
--cc=kan.liang@linux.intel.com \
--cc=leo.yan@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liwei391@huawei.com \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=naveen.n.rao@linux.vnet.ibm.com \
--cc=ndesaulniers@google.com \
--cc=nick.gasson@arm.com \
--cc=peterz@infradead.org \
--cc=shikemeng@huawei.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox