public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Osipenko <digetx@gmail.com>
To: "Thierry Reding" <thierry.reding@gmail.com>,
	"Jonathan Hunter" <jonathanh@nvidia.com>,
	"Laxman Dewangan" <ldewangan@nvidia.com>,
	"Wolfram Sang" <wsa@the-dreams.de>,
	"Michał Mirosław" <mirq-linux@rere.qmqm.pl>,
	"Andy Shevchenko" <andy.shevchenko@gmail.com>
Cc: linux-i2c@vger.kernel.org, linux-tegra@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH v5 00/36] Improvements for Tegra I2C driver
Date: Sun,  6 Sep 2020 21:50:03 +0300	[thread overview]
Message-ID: <20200906185039.22700-1-digetx@gmail.com> (raw)

Hello!

This series performs refactoring of the Tegra I2C driver code and hardens
the atomic-transfer mode.

Changelog:

v5: - Dropped the "Factor out runtime PM and hardware initialization"
      patch, like it was suggested by Michał Mirosław. Instead a less
      invasive "Factor out hardware initialization into separate function"
      patch added, it doesn't touch the RPM initialization.

    - The "Remove outdated barrier()" patch now removes outdated comments.

    - Updated commit description of the "Remove "dma" variable" patch,
      saying that the transfer mode may be changed by a callee. This was
      suggested by Michał Mirosław.

    - Reworked the "Clean up and improve comments" patch. Couple more
      comments are corrected and reworded now.

    - Added r-b's from Michał Mirosław.

    - New patches:

        i2c: tegra: Mask interrupt in tegra_i2c_issue_bus_clear()
        i2c: tegra: Remove redundant check in tegra_i2c_issue_bus_clear()
        i2c: tegra: Don't fall back to PIO mode if DMA configuration fails
        i2c: tegra: Clean up variable types
        i2c: tegra: Improve tegra_i2c_dev structure

v4: - Reordered patches in the fixes/features/cleanups order like it was
      suggested by Andy Shevchenko.

    - Now using clk-bulk API, which was suggested by Andy Shevchenko.

    - Reworked "Make tegra_i2c_flush_fifos() usable in atomic transfer"
      patch to use iopoll API, which was suggested by Andy Shevchenko.

    - Separated "Clean up probe function" into several smaller patches.

    - Squashed "Add missing newline before returns" patch into
      "Clean up whitespaces, newlines and indentation".

    - The "Drop '_timeout' from wait/poll function names" is renamed to
      "Rename wait/poll functions".

    - The "Use reset_control_reset()" is changed to not fail tegra_i2c_init(),
      but only emit warning. This should be more friendly behaviour in oppose
      to having a non-bootable machine if reset-control fails.

    - New patches:

        i2c: tegra: Remove error message used for devm_request_irq() failure
        i2c: tegra: Use devm_platform_get_and_ioremap_resource()
        i2c: tegra: Use platform_get_irq()
        i2c: tegra: Use clk-bulk helpers
        i2c: tegra: Remove bogus barrier()
        i2c: tegra: Factor out register polling into separate function
        i2c: tegra: Consolidate error handling in tegra_i2c_xfer_msg()
        i2c: tegra: Clean up and improve comments
        i2c: tegra: Rename couple "ret" variables to "err"

v3: - Optimized "Make tegra_i2c_flush_fifos() usable in atomic transfer"
      patch by pre-checking FIFO state before starting to poll using
      ktime API, which may be expensive under some circumstances.

    - The "Clean up messages in the code" patch now makes all messages
      to use proper capitalization of abbreviations. Thanks to Andy Shevchenko
      and Michał Mirosław for the suggestion.

    - The "Remove unnecessary whitespaces and newlines" patch is transformed
      into "Clean up whitespaces and newlines", it now also adds missing
      newlines and spaces.

    - Reworked the "Clean up probe function" patch in accordance to
      suggestion from Michał Mirosław by factoring out only parts of
      the code that make error unwinding cleaner.

    - Added r-b from Michał Mirosław.

    - Added more patches:

        i2c: tegra: Reorder location of functions in the code
        i2c: tegra: Factor out packet header setup from tegra_i2c_xfer_msg()
        i2c: tegra: Remove "dma" variable
        i2c: tegra: Initialization div-clk rate unconditionally
        i2c: tegra: Remove i2c_dev.clk_divisor_non_hs_mode member

v2: - Cleaned more messages in the "Clean up messages in the code" patch.

    - The error code of reset_control_reset() is checked now.

    - Added these new patches to clean up couple more things:

        i2c: tegra: Check errors for both positive and negative values
        i2c: tegra: Improve coding style of tegra_i2c_wait_for_config_load()
        i2c: tegra: Remove unnecessary whitespaces and newlines
        i2c: tegra: Rename variable in tegra_i2c_issue_bus_clear()
        i2c: tegra: Improve driver module description

Dmitry Osipenko (36):
  i2c: tegra: Make tegra_i2c_flush_fifos() usable in atomic transfer
  i2c: tegra: Handle potential error of tegra_i2c_flush_fifos()
  i2c: tegra: Mask interrupt in tegra_i2c_issue_bus_clear()
  i2c: tegra: Initialization div-clk rate unconditionally
  i2c: tegra: Remove i2c_dev.clk_divisor_non_hs_mode member
  i2c: tegra: Runtime PM always available on Tegra
  i2c: tegra: Remove error message used for devm_request_irq() failure
  i2c: tegra: Use reset_control_reset()
  i2c: tegra: Use devm_platform_get_and_ioremap_resource()
  i2c: tegra: Use platform_get_irq()
  i2c: tegra: Use clk-bulk helpers
  i2c: tegra: Move out all device-tree parsing into tegra_i2c_parse_dt()
  i2c: tegra: Clean up probe function
  i2c: tegra: Remove likely/unlikely from the code
  i2c: tegra: Remove outdated barrier()
  i2c: tegra: Remove "dma" variable from tegra_i2c_xfer_msg()
  i2c: tegra: Remove redundant check in tegra_i2c_issue_bus_clear()
  i2c: tegra: Don't fall back to PIO mode if DMA configuration fails
  i2c: tegra: Improve formatting of function variables
  i2c: tegra: Improve coding style of tegra_i2c_wait_for_config_load()
  i2c: tegra: Rename wait/poll functions
  i2c: tegra: Rename variable in tegra_i2c_issue_bus_clear()
  i2c: tegra: Factor out error recovery from tegra_i2c_xfer_msg()
  i2c: tegra: Factor out packet header setup from tegra_i2c_xfer_msg()
  i2c: tegra: Factor out register polling into separate function
  i2c: tegra: Factor out hardware initialization into separate function
  i2c: tegra: Reorder location of functions in the code
  i2c: tegra: Check errors for both positive and negative values
  i2c: tegra: Consolidate error handling in tegra_i2c_xfer_msg()
  i2c: tegra: Clean up printk messages
  i2c: tegra: Clean up whitespaces, newlines and indentation
  i2c: tegra: Clean up and improve comments
  i2c: tegra: Clean up variable types
  i2c: tegra: Improve driver module description
  i2c: tegra: Rename couple "ret" variables to "err"
  i2c: tegra: Improve tegra_i2c_dev structure

 drivers/i2c/busses/i2c-tegra.c | 1396 ++++++++++++++++----------------
 1 file changed, 677 insertions(+), 719 deletions(-)

-- 
2.27.0


             reply	other threads:[~2020-09-06 18:52 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-06 18:50 Dmitry Osipenko [this message]
2020-09-06 18:50 ` [PATCH v5 01/36] i2c: tegra: Make tegra_i2c_flush_fifos() usable in atomic transfer Dmitry Osipenko
2020-09-07  7:56   ` Andy Shevchenko
2020-09-07 14:31     ` Dmitry Osipenko
2020-09-06 18:50 ` [PATCH v5 02/36] i2c: tegra: Handle potential error of tegra_i2c_flush_fifos() Dmitry Osipenko
2020-09-06 18:50 ` [PATCH v5 03/36] i2c: tegra: Mask interrupt in tegra_i2c_issue_bus_clear() Dmitry Osipenko
2020-09-06 18:50 ` [PATCH v5 04/36] i2c: tegra: Initialization div-clk rate unconditionally Dmitry Osipenko
2020-09-06 18:50 ` [PATCH v5 05/36] i2c: tegra: Remove i2c_dev.clk_divisor_non_hs_mode member Dmitry Osipenko
2020-09-06 18:50 ` [PATCH v5 06/36] i2c: tegra: Runtime PM always available on Tegra Dmitry Osipenko
2020-09-07  8:10   ` Andy Shevchenko
2020-09-07 14:31     ` Dmitry Osipenko
2020-09-07 15:05       ` Andy Shevchenko
2020-09-07 15:25         ` Dmitry Osipenko
2020-09-07 15:34           ` Andy Shevchenko
2020-09-07 16:06             ` Dmitry Osipenko
2020-09-06 18:50 ` [PATCH v5 07/36] i2c: tegra: Remove error message used for devm_request_irq() failure Dmitry Osipenko
2020-09-06 18:50 ` [PATCH v5 08/36] i2c: tegra: Use reset_control_reset() Dmitry Osipenko
2020-09-07  8:13   ` Andy Shevchenko
2020-09-07 14:33     ` Dmitry Osipenko
2020-09-06 18:50 ` [PATCH v5 09/36] i2c: tegra: Use devm_platform_get_and_ioremap_resource() Dmitry Osipenko
2020-09-06 18:50 ` [PATCH v5 10/36] i2c: tegra: Use platform_get_irq() Dmitry Osipenko
2020-09-06 18:50 ` [PATCH v5 11/36] i2c: tegra: Use clk-bulk helpers Dmitry Osipenko
2020-09-07  8:21   ` Andy Shevchenko
2020-09-07 14:33     ` Dmitry Osipenko
2020-09-06 18:50 ` [PATCH v5 12/36] i2c: tegra: Move out all device-tree parsing into tegra_i2c_parse_dt() Dmitry Osipenko
2020-09-06 18:50 ` [PATCH v5 13/36] i2c: tegra: Clean up probe function Dmitry Osipenko
2020-09-07  8:20   ` Andy Shevchenko
2020-09-07 14:33     ` Dmitry Osipenko
2020-09-06 18:50 ` [PATCH v5 14/36] i2c: tegra: Remove likely/unlikely from the code Dmitry Osipenko
2020-09-06 18:50 ` [PATCH v5 15/36] i2c: tegra: Remove outdated barrier() Dmitry Osipenko
2020-09-06 18:50 ` [PATCH v5 16/36] i2c: tegra: Remove "dma" variable from tegra_i2c_xfer_msg() Dmitry Osipenko
2020-09-06 18:50 ` [PATCH v5 17/36] i2c: tegra: Remove redundant check in tegra_i2c_issue_bus_clear() Dmitry Osipenko
2020-09-06 18:50 ` [PATCH v5 18/36] i2c: tegra: Don't fall back to PIO mode if DMA configuration fails Dmitry Osipenko
2020-09-06 18:50 ` [PATCH v5 19/36] i2c: tegra: Improve formatting of function variables Dmitry Osipenko
2020-09-06 18:50 ` [PATCH v5 20/36] i2c: tegra: Improve coding style of tegra_i2c_wait_for_config_load() Dmitry Osipenko
2020-09-06 18:50 ` [PATCH v5 21/36] i2c: tegra: Rename wait/poll functions Dmitry Osipenko
2020-09-06 18:50 ` [PATCH v5 22/36] i2c: tegra: Rename variable in tegra_i2c_issue_bus_clear() Dmitry Osipenko
2020-09-06 18:50 ` [PATCH v5 23/36] i2c: tegra: Factor out error recovery from tegra_i2c_xfer_msg() Dmitry Osipenko
2020-09-06 18:50 ` [PATCH v5 24/36] i2c: tegra: Factor out packet header setup " Dmitry Osipenko
2020-09-06 18:50 ` [PATCH v5 25/36] i2c: tegra: Factor out register polling into separate function Dmitry Osipenko
2020-09-06 18:50 ` [PATCH v5 26/36] i2c: tegra: Factor out hardware initialization " Dmitry Osipenko
2020-09-07  8:25   ` Andy Shevchenko
2020-09-06 18:50 ` [PATCH v5 27/36] i2c: tegra: Reorder location of functions in the code Dmitry Osipenko
2020-09-07  8:27   ` Andy Shevchenko
2020-09-07 14:36     ` Dmitry Osipenko
2020-09-06 18:50 ` [PATCH v5 28/36] i2c: tegra: Check errors for both positive and negative values Dmitry Osipenko
2020-09-06 18:50 ` [PATCH v5 29/36] i2c: tegra: Consolidate error handling in tegra_i2c_xfer_msg() Dmitry Osipenko
2020-09-06 18:50 ` [PATCH v5 30/36] i2c: tegra: Clean up printk messages Dmitry Osipenko
2020-09-06 18:50 ` [PATCH v5 31/36] i2c: tegra: Clean up whitespaces, newlines and indentation Dmitry Osipenko
2020-09-06 18:50 ` [PATCH v5 32/36] i2c: tegra: Clean up and improve comments Dmitry Osipenko
2020-09-07  8:29   ` Andy Shevchenko
2020-09-06 18:50 ` [PATCH v5 33/36] i2c: tegra: Clean up variable types Dmitry Osipenko
2020-09-07  8:30   ` Andy Shevchenko
2020-09-06 18:50 ` [PATCH v5 34/36] i2c: tegra: Improve driver module description Dmitry Osipenko
2020-09-06 18:50 ` [PATCH v5 35/36] i2c: tegra: Rename couple "ret" variables to "err" Dmitry Osipenko
2020-09-07  8:31   ` Andy Shevchenko
2020-09-06 18:50 ` [PATCH v5 36/36] i2c: tegra: Improve tegra_i2c_dev structure Dmitry Osipenko
2020-09-07  8:32   ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200906185039.22700-1-digetx@gmail.com \
    --to=digetx@gmail.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=jonathanh@nvidia.com \
    --cc=ldewangan@nvidia.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=mirq-linux@rere.qmqm.pl \
    --cc=thierry.reding@gmail.com \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox