Re: [PATCH v5 06/36] i2c: tegra: Runtime PM always available on Tegra

Andy Shevchenko
2020-09-07T08:11:38Z

On Sun, Sep 6, 2020 at 9:51 PM Dmitry Osipenko <digetx@gmail.com> wrote:
>
> The runtime PM is guaranteed to be always available on Tegra after commit
> 40b2bb1b132a ("ARM: tegra: enforce PM requirement"). Hence let's remove
> all the RPM-availability checking and handling from the code.

> + ret = pm_runtime_get_sync(i2c_dev->dev);
> + if (ret < 0) {
> + dev_err(dev, "runtime resume failed\n");
> + goto disable_rpm;

As in the original code here is a refcount leak.
Should call pm_runtime_put_noidle(). (Possible to use goto put_rpm;
but in that case the code a bit confusing to the reader)

> }

> put_rpm:
> + pm_runtime_put_sync(&pdev->dev);
>
> disable_rpm:

--
With Best Regards,
Andy Shevchenko