public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Christoph Hellwig <hch@lst.de>
Cc: arnd@arndb.de, linux-kernel@vger.kernel.org,
	Christophe Leroy <christophe.leroy@csgroup.eu>
Subject: Re: [PATCH v2] /dev/zero: also implement ->read
Date: Mon, 7 Sep 2020 10:21:14 +0200	[thread overview]
Message-ID: <20200907082114.GA714195@kroah.com> (raw)
In-Reply-To: <20200907075143.2023440-1-hch@lst.de>

On Mon, Sep 07, 2020 at 09:51:43AM +0200, Christoph Hellwig wrote:
> Christophe reported a major speedup due to avoiding the iov_iter
> overhead, so just add this trivial function.
> 
> Suggested-by: Christophe Leroy <christophe.leroy@csgroup.eu>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> Tested-by: Christophe Leroy <christophe.leroy@csgroup.eu>
> ---
> 
> Changes since v1:
>  - fix the Suggested-by: tag
>  - report the actually read bytes in case of a partial clear_user
>  - remove an impossible to hit conditional
> 
>  drivers/char/mem.c | 28 ++++++++++++++++++++++++++++
>  1 file changed, 28 insertions(+)

I already merged your v1 into my tree, do you want me to revert that and
then add this, or can you send me the diff to apply instead?  I can't
rebase my public trees.

thanks,

greg k-h

  reply	other threads:[~2020-09-07  8:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-07  7:51 [PATCH v2] /dev/zero: also implement ->read Christoph Hellwig
2020-09-07  8:21 ` Greg KH [this message]
2020-09-07  8:21   ` Christoph Hellwig
2020-09-07  8:45     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200907082114.GA714195@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=arnd@arndb.de \
    --cc=christophe.leroy@csgroup.eu \
    --cc=hch@lst.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox