From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60357C433E2 for ; Tue, 8 Sep 2020 16:41:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 003F620759 for ; Tue, 8 Sep 2020 16:41:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="AUJqw5Q5" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732046AbgIHQlE (ORCPT ); Tue, 8 Sep 2020 12:41:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60598 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732052AbgIHQhR (ORCPT ); Tue, 8 Sep 2020 12:37:17 -0400 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C5406C061A12 for ; Tue, 8 Sep 2020 07:04:19 -0700 (PDT) Received: by mail-wr1-x444.google.com with SMTP id s12so867986wrw.11 for ; Tue, 08 Sep 2020 07:04:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=8M8FQZb2HgpFZLZz+2kHkv7PQ6hJJGgLuAcXeYJHXoc=; b=AUJqw5Q5yIKjjHv+TlphEapfGqGOE84LTkY2zdyRmrMCZc4UN5YC2gkzDw8k0vGBgc Cs7Qk83LMgV1TESF82VJ5kAJMn0dMUMkUDY+W7j02XikANSGY+Q5vMIg1bXFdpVU702p JpMtWNealLQk01KqN+ZWJF9EN7XmeVpCS4XuBlniZDTYtXI3FFvIfpE7OunsxJOYAvkj OKfewt829N5WohHh7McC0bRqVQDay13XKTzmxsGafZIAawYUqLmaZ0ivQKWBlUoAMXEo 4D0NcBfydlPrudfK8LsP0K4eh5sKjdtBeSEV/jsf0BCwLordxeK93nP6TJ6FV7R5+i8w tvVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=8M8FQZb2HgpFZLZz+2kHkv7PQ6hJJGgLuAcXeYJHXoc=; b=ssYlj6hz13l6HtrgdAL3IkaWPIGcpM+KGnJb474hxuUgVYf7+U9sVFIKb1FbdV00QR BUPkazMT3pEd7JWW+kypO0lSqNOZg9uJnf4Pw4iMwoo1o9C+aOeZ4n3W9QdsAuqPrU9z WTo4trlERz9TBQcWo3Fp5XuVOZKmMs1M7ZIPV8cLf37v3i8d894SzKbXC8kowjksG5q2 5c090IRUi8XFq8DMpaZ2w/ajfXGkpxxRsRNomNwM2MFEvQhHhhBYT3Kf0yUhbmcpj7QB 3qhmzF21Mbn+T78Q10ghMiH+WHOQoIbcu6ejtMMDoFlN/0cpBCQqTCGuHnAwYPocNpfv 3Pcg== X-Gm-Message-State: AOAM5326chP3HDfw9HC0EeL3blj/zdVyPZoMBF9LLJ5x3k+8r5h4OG4B HoISqOLCJ62bUHUOxK0VgPKCTw== X-Google-Smtp-Source: ABdhPJzm2yDttST5j8TaF3B2Cm917dhqrg3b0B96Ye1IYiXRwc7ozDdXKCLbFqn5vdgCfieZFk4ipw== X-Received: by 2002:adf:e8ce:: with SMTP id k14mr28758614wrn.394.1599573858090; Tue, 08 Sep 2020 07:04:18 -0700 (PDT) Received: from dell ([91.110.221.179]) by smtp.gmail.com with ESMTPSA id i11sm11288646wre.32.2020.09.08.07.04.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Sep 2020 07:04:17 -0700 (PDT) Date: Tue, 8 Sep 2020 15:04:15 +0100 From: Lee Jones To: dillon.minfei@gmail.com Cc: linus.walleij@linaro.org, bgolaszewski@baylibre.com, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH: V2 2/2] gpio: tc35894: Disable Direct KBD interrupts to enable gpio irq Message-ID: <20200908140415.GW4400@dell> References: <1599118222-18990-1-git-send-email-dillon.minfei@gmail.com> <1599118222-18990-3-git-send-email-dillon.minfei@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1599118222-18990-3-git-send-email-dillon.minfei@gmail.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 03 Sep 2020, dillon.minfei@gmail.com wrote: > From: dillon min > > On tc35894, have to disable direct keypad interrupts to make > it as general purpose interrupts functionality work. > if not, after chip reset, IRQST(0x91) will always 0x20, > IRQN always low level, can't be clear. > > Configure DIRECTx to enable general purpose gpio mode, > else read GPIOMISx register always zero in irq routine. > > verified on tc35894, need more test on other tc3589x. > > Signed-off-by: dillon min > --- > > V1 -> V2: > Add DIRECTx register configuration to active general purpose gpio mode. > > drivers/gpio/gpio-tc3589x.c | 18 ++++++++++++++++-- > include/linux/mfd/tc3589x.h | 6 ++++++ Acked-by: Lee Jones -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog