* [PATCH] dt-bindings: leds: common: Add missing triggers
@ 2020-08-24 10:39 Michal Simek
2020-09-08 22:23 ` Rob Herring
0 siblings, 1 reply; 2+ messages in thread
From: Michal Simek @ 2020-08-24 10:39 UTC (permalink / raw)
To: linux-kernel, monstr, michal.simek, git
Cc: Dan Murphy, Jacek Anaszewski, Pavel Machek, Rob Herring,
devicetree, linux-leds
Xilinx ZynqMP zcu100/ultra96 v1 defines additional triggers which are not
covered by common.yaml. The patch adds missing triggers for this platform.
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---
There are a lot of other triggers which are missing but the patch focus on
fixing my platform
---
Documentation/devicetree/bindings/leds/common.yaml | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/Documentation/devicetree/bindings/leds/common.yaml b/Documentation/devicetree/bindings/leds/common.yaml
index a2a541bca73c..c3d728a06782 100644
--- a/Documentation/devicetree/bindings/leds/common.yaml
+++ b/Documentation/devicetree/bindings/leds/common.yaml
@@ -82,6 +82,8 @@ properties:
enum:
# LED will act as a back-light, controlled by the framebuffer system
- backlight
+ # LED indicates enabling power for bluetooth device
+ - bluetooth-power
# LED will turn on (but for leds-gpio see "default-state" property in
# Documentation/devicetree/bindings/leds/leds-gpio.yaml)
- default-on
@@ -97,6 +99,9 @@ properties:
# LED alters the brightness for the specified duration with one software
# timer (requires "led-pattern" property)
- pattern
+ # LED flashes based on networking activity on tx and rx channels
+ - phy0tx
+ - phy0rx
led-pattern:
description: |
--
2.28.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] dt-bindings: leds: common: Add missing triggers
2020-08-24 10:39 [PATCH] dt-bindings: leds: common: Add missing triggers Michal Simek
@ 2020-09-08 22:23 ` Rob Herring
0 siblings, 0 replies; 2+ messages in thread
From: Rob Herring @ 2020-09-08 22:23 UTC (permalink / raw)
To: Michal Simek
Cc: linux-kernel, monstr, git, Dan Murphy, Jacek Anaszewski,
Pavel Machek, devicetree, linux-leds
On Mon, Aug 24, 2020 at 12:39:27PM +0200, Michal Simek wrote:
> Xilinx ZynqMP zcu100/ultra96 v1 defines additional triggers which are not
> covered by common.yaml. The patch adds missing triggers for this platform.
>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
>
> There are a lot of other triggers which are missing but the patch focus on
> fixing my platform
The idea was to standardize these and not add a bunch of similar ones.
Also, there's the 'function' property which is preferred as well as the
trigger source binding now to better associate LEDs with specific h/w.
Rob
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-09-08 22:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-08-24 10:39 [PATCH] dt-bindings: leds: common: Add missing triggers Michal Simek
2020-09-08 22:23 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox