From: Petr Mladek <pmladek@suse.com>
To: John Ogness <john.ogness@linutronix.de>
Cc: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Steven Rostedt <rostedt@goodmis.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
Peter Zijlstra <peterz@infradead.org>,
Andrea Parri <parri.andrea@gmail.com>,
Paul McKenney <paulmck@kernel.org>,
kexec@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH printk v4 3/6] printk: ringbuffer: clear initial reserved fields
Date: Wed, 9 Sep 2020 11:34:31 +0200 [thread overview]
Message-ID: <20200909093431.GE3864@alley> (raw)
In-Reply-To: <20200908202859.2736-4-john.ogness@linutronix.de>
On Tue 2020-09-08 22:34:56, John Ogness wrote:
> prb_reserve() will set some meta data values and leave others
> uninitialized (or rather, containing the values of the previous
> wrap). Simplify the API by always clearing out all the fields.
> Only the sequence number is filled in. The caller is now
> responsible for filling in the rest of the meta data fields.
> In particular, for correctly filling in text and dict lengths.
>
> Signed-off-by: John Ogness <john.ogness@linutronix.de>
Reviewed-by: Petr Mladek <pmladek@suse.com>
Best Regards,
Petr
next prev parent reply other threads:[~2020-09-09 9:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-08 20:28 [PATCH printk v4 0/6] printk: reimplement LOG_CONT handling John Ogness
2020-09-08 20:28 ` [PATCH printk v4 1/6] printk: ringbuffer: relocate get_data() John Ogness
2020-09-08 20:28 ` [PATCH printk v4 2/6] printk: ringbuffer: add BLK_DATALESS() macro John Ogness
2020-09-08 20:28 ` [PATCH printk v4 3/6] printk: ringbuffer: clear initial reserved fields John Ogness
2020-09-09 9:34 ` Petr Mladek [this message]
2020-09-08 20:28 ` [PATCH printk v4 4/6] printk: ringbuffer: change representation of states John Ogness
2020-09-09 10:01 ` Petr Mladek
2020-09-08 20:28 ` [PATCH printk v4 5/6] printk: ringbuffer: add finalization/extension support John Ogness
2020-09-09 6:50 ` kernel test robot
2020-09-09 10:40 ` Dan Carpenter
2020-09-09 15:22 ` Petr Mladek
2020-09-08 20:28 ` [PATCH printk v4 6/6] printk: reimplement log_cont using record extension John Ogness
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200909093431.GE3864@alley \
--to=pmladek@suse.com \
--cc=gregkh@linuxfoundation.org \
--cc=john.ogness@linutronix.de \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=parri.andrea@gmail.com \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky.work@gmail.com \
--cc=sergey.senozhatsky@gmail.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox