From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Jiri Olsa <jolsa@redhat.com>, Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Stephane Eranian <eranian@google.com>,
LKML <linux-kernel@vger.kernel.org>,
Ian Rogers <irogers@google.com>
Subject: Re: [PATCH 1/3] perf list: Remove dead code in argument check
Date: Wed, 9 Sep 2020 09:27:55 -0300 [thread overview]
Message-ID: <20200909122755.GA3788224@kernel.org> (raw)
In-Reply-To: <20200909055849.469612-1-namhyung@kernel.org>
Em Wed, Sep 09, 2020 at 02:58:47PM +0900, Namhyung Kim escreveu:
> The sep is already checked being not NULL. The code seems to be a
> leftover from some refactoring.
>
> Signed-off-by: Namhyung Kim <namhyung@kernel.org>
There is a missing --- separator from the description to the patch, I
had to add it so that 'git am' works on it, please check.
- Arnaldo
I.e. it should be right here:
---
>
> diff --git a/tools/perf/builtin-list.c b/tools/perf/builtin-list.c
> index 0a7fe4cb5555..10ab5e40a34f 100644
> --- a/tools/perf/builtin-list.c
> +++ b/tools/perf/builtin-list.c
> @@ -92,13 +92,6 @@ int cmd_list(int argc, const char **argv)
> else if ((sep = strchr(argv[i], ':')) != NULL) {
> int sep_idx;
>
> - if (sep == NULL) {
> - print_events(argv[i], raw_dump, !desc_flag,
> - long_desc_flag,
> - details_flag,
> - deprecated);
> - continue;
> - }
> sep_idx = sep - argv[i];
> s = strdup(argv[i]);
> if (s == NULL)
> --
> 2.28.0.526.ge36021eeef-goog
>
--
- Arnaldo
next prev parent reply other threads:[~2020-09-09 14:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-09 5:58 [PATCH 1/3] perf list: Remove dead code in argument check Namhyung Kim
2020-09-09 5:58 ` [PATCH 2/3] perf list: Do not print 'Metric Groups:' unnecessarily Namhyung Kim
2020-09-09 12:29 ` Arnaldo Carvalho de Melo
2020-09-09 5:58 ` [PATCH 3/3] perf list: Add 'pfm' to list libpfm4 events Namhyung Kim
2020-09-21 6:34 ` Namhyung Kim
2020-09-22 20:42 ` Jiri Olsa
2020-09-22 22:42 ` Namhyung Kim
2020-09-23 5:10 ` Jiri Olsa
2020-09-22 20:50 ` Ian Rogers
2020-09-22 22:45 ` Namhyung Kim
2020-09-09 12:27 ` Arnaldo Carvalho de Melo [this message]
2020-09-09 12:58 ` [PATCH 1/3] perf list: Remove dead code in argument check Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200909122755.GA3788224@kernel.org \
--to=acme@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=alexander.shishkin@linux.intel.com \
--cc=eranian@google.com \
--cc=irogers@google.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox