From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Jiri Olsa <jolsa@redhat.com>, Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Stephane Eranian <eranian@google.com>,
LKML <linux-kernel@vger.kernel.org>,
Ian Rogers <irogers@google.com>
Subject: Re: [PATCH 2/3] perf list: Do not print 'Metric Groups:' unnecessarily
Date: Wed, 9 Sep 2020 09:29:10 -0300 [thread overview]
Message-ID: <20200909122910.GB3788224@kernel.org> (raw)
In-Reply-To: <20200909055849.469612-2-namhyung@kernel.org>
Em Wed, Sep 09, 2020 at 02:58:48PM +0900, Namhyung Kim escreveu:
> It was printed unconditionally even if nothing is printed.
> Check if the output list empty when filter is given.
>
> Before:
> $ ./perf list duration
>
> List of pre-defined events (to be used in -e):
>
> duration_time [Tool event]
>
> Metric Groups:
>
> After:
> $ ./perf list duration
>
> List of pre-defined events (to be used in -e):
>
> duration_time [Tool event]
> Signed-off-by: Namhyung Kim <namhyung@kernel.org>
---
Thanks, applied.
- Arnaldo
>
> diff --git a/tools/perf/util/metricgroup.c b/tools/perf/util/metricgroup.c
> index 8831b964288f..38464d7d2d63 100644
> --- a/tools/perf/util/metricgroup.c
> +++ b/tools/perf/util/metricgroup.c
> @@ -535,10 +535,12 @@ void metricgroup__print(bool metrics, bool metricgroups, char *filter,
> }
> }
>
> - if (metricgroups && !raw)
> - printf("\nMetric Groups:\n\n");
> - else if (metrics && !raw)
> - printf("\nMetrics:\n\n");
> + if (!filter || !rblist__empty(&groups)) {
> + if (metricgroups && !raw)
> + printf("\nMetric Groups:\n\n");
> + else if (metrics && !raw)
> + printf("\nMetrics:\n\n");
> + }
>
> for (node = rb_first_cached(&groups.entries); node; node = next) {
> struct mep *me = container_of(node, struct mep, nd);
> --
> 2.28.0.526.ge36021eeef-goog
>
--
- Arnaldo
next prev parent reply other threads:[~2020-09-09 14:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-09 5:58 [PATCH 1/3] perf list: Remove dead code in argument check Namhyung Kim
2020-09-09 5:58 ` [PATCH 2/3] perf list: Do not print 'Metric Groups:' unnecessarily Namhyung Kim
2020-09-09 12:29 ` Arnaldo Carvalho de Melo [this message]
2020-09-09 5:58 ` [PATCH 3/3] perf list: Add 'pfm' to list libpfm4 events Namhyung Kim
2020-09-21 6:34 ` Namhyung Kim
2020-09-22 20:42 ` Jiri Olsa
2020-09-22 22:42 ` Namhyung Kim
2020-09-23 5:10 ` Jiri Olsa
2020-09-22 20:50 ` Ian Rogers
2020-09-22 22:45 ` Namhyung Kim
2020-09-09 12:27 ` [PATCH 1/3] perf list: Remove dead code in argument check Arnaldo Carvalho de Melo
2020-09-09 12:58 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200909122910.GB3788224@kernel.org \
--to=acme@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=alexander.shishkin@linux.intel.com \
--cc=eranian@google.com \
--cc=irogers@google.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox