From: Borislav Petkov <bp@alien8.de>
To: "Luck, Tony" <tony.luck@intel.com>
Cc: x86-ml <x86@kernel.org>, lkml <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH] x86/mce: Make mce_rdmsrl() do a plain RDMSR only
Date: Wed, 9 Sep 2020 22:03:21 +0200 [thread overview]
Message-ID: <20200909200321.GG12237@zn.tnic> (raw)
In-Reply-To: <20200909182051.GA31883@agluck-desk2.amr.corp.intel.com>
On Wed, Sep 09, 2020 at 11:20:51AM -0700, Luck, Tony wrote:
> Do we think there will be other places where we want this
> MSR-or-die behaviour?
MSR-or-die - I like that. That belongs on a T-shirt. :-)
> If there are, then most of this belongs elsewhere from
> arch/x86/kernel/cpu/mce/core.c
Yeah, I can't think of any other users needing this ATM. But if they do,
lifting those and moving them somewhere else is trivial.
> The "_once" version seems a little pointless when the next statement
> in the function is "panic()".
True, removed.
> "warn" seems understated for an error that is going to crash the system.
> Just go for "pr_emerg()".
Done.
> There seems no consistency on using "rIP" or "RIP" ... but I think "RIP"
> is slightly ahead.
The "r" in rIP means that it can be RIP or EIP and that code builds on
32-bit too.
> nitpick: I don't thing Architectural needs to be capitalized.
Done.
> Ugh. Is this why you have warn_once() ... because panic might return?
People tend to put all kinds of things in panic() and I want to make
sure that even if it returns for whatever reason, at some point in
the future, we don't make any further progress here. Think of it as a
paranoid precation of sorts...
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2020-09-09 20:03 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-06 21:21 [RFC PATCH] x86/mce: Make mce_rdmsrl() do a plain RDMSR only Borislav Petkov
2020-09-07 20:06 ` Luck, Tony
2020-09-08 9:46 ` Borislav Petkov
2020-09-08 10:08 ` Borislav Petkov
2020-09-08 15:07 ` Luck, Tony
2020-09-08 15:25 ` Borislav Petkov
2020-09-09 11:30 ` Borislav Petkov
2020-09-09 18:20 ` Luck, Tony
2020-09-09 20:03 ` Borislav Petkov [this message]
2020-09-10 18:29 ` Borislav Petkov
2020-09-10 18:38 ` [PATCH -v2] x86/mce: Make mce_rdmsrl() panic on an inaccessible MSR Borislav Petkov
2020-09-10 18:42 ` [RFC PATCH] x86/mce: Make mce_rdmsrl() do a plain RDMSR only Luck, Tony
2020-09-10 18:54 ` Borislav Petkov
2020-09-10 19:43 ` Luck, Tony
2020-09-07 20:16 ` Andy Lutomirski
2020-09-07 20:27 ` Borislav Petkov
2020-09-11 9:47 ` [tip: ras/core] x86/mce: Make mce_rdmsrl() panic on an inaccessible MSR tip-bot2 for Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200909200321.GG12237@zn.tnic \
--to=bp@alien8.de \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox