Re: [PATCH 2/2] Add driver for Moortec MR75203 PVT controller

Andy Shevchenko
2020-09-10T09:46:53Z

On Thu, Sep 10, 2020 at 03:27:11PM +0800, Tanwar, Rahul wrote:
> On 9/9/2020 11:05 pm, Guenter Roeck wrote:
> > On 9/8/20 11:52 PM, Rahul Tanwar wrote:

...

> >> +static int pvt_get_regmap(struct platform_device *pdev, char *reg_name)
> >> +{
> >> + struct device *dev = &pdev->dev;
> >> + struct pvt_device *pvt = platform_get_drvdata(pdev);
> > I am quite at loss how this is supposed to work. Platform driver
> > data is not initialized with a pointer to struct pvt_device at this point.
> > How does this code not crash ? What am I missing ?
>
> Big mistake on my part. Last minute change based on internal review feedback
> about moving platform_set_drvdata() at the end of probe. I will fix it in v2.
> Thanks.

Since IIRC it was me who suggested this I should say that reviewer can make
mistakes, on the other hand contributor should have had known their code to
refuse certain changes.

--
With Best Regards,
Andy Shevchenko