Re: [PATCH 2/2] Add driver for Moortec MR75203 PVT controller

Andy Shevchenko
2020-09-10T09:34:10Z

On Thu, Sep 10, 2020 at 03:26:04PM +0800, Tanwar, Rahul wrote:
> On 9/9/2020 6:33 pm, Andy Shevchenko wrote:
> > On Wed, Sep 09, 2020 at 02:52:05PM +0800, Rahul Tanwar wrote:

...

> >> +#include <linux/of.h>
> > I don't see anything special about OF here.
> > Perhaps
> > mod_devicetable.h
> > property.h
> > ?
>
> of.h is needed because of of_property_read_u8_array(). I will add
> mod_devicetable.h.
> property.h seems not required at all.

if you use device property API then it will be more generic.

...

> >> +static struct regmap_config pvt_regmap_config = {
> >> + .reg_bits = 32,
> >> + .reg_stride = 4,
> >> + .val_bits = 32,
> > How do you use regmap's lock?
>
> We mutex lock whenever read temperature or voltage values from the registers.
> All non-probe/non-init paths. We do not override regmap's internal lock.

Exactly and my point is why do we have too many locks?

> >> +};

--
With Best Regards,
Andy Shevchenko