Re: [PATCH 2/2] Add driver for Moortec MR75203 PVT controller

Tanwar, Rahul
2020-09-10T10:42:47Z

On 10/9/2020 6:35 pm, Philipp Zabel wrote:
> On Wed, 2020-09-09 at 14:52 +0800, Rahul Tanwar wrote:
>> PVT controller (MR75203) is used to configure & control
>> Moortec embedded analog IP which contains temprature
>> sensor(TS), voltage monitor(VM) & process detector(PD)
>> modules. Add driver to support MR75203 PVT controller.
>>
>> Signed-off-by: Rahul Tanwar <rahul.tanwar@linux.intel.com>
>> ---
> [...]
>> +static int mr75203_probe(struct platform_device *pdev)
>> +{
>> + const struct hwmon_channel_info **pvt_info;
>> + u32 ts_num, vm_num, pd_num, val, index, i;
>> + struct device *dev = &pdev->dev;
>> + u32 *temp_config, *in_config;
>> + struct device *hwmon_dev;
>> + struct pvt_device *pvt;
>> + int ret;
>> +
>> + pvt = devm_kzalloc(dev, sizeof(*pvt), GFP_KERNEL);
>> + if (!pvt)
>> + return -ENOMEM;
>> +
>> + ret = pvt_get_regmap(pdev, "common");
>> + if (ret)
>> + return ret;
>> +
>> + pvt->rst = devm_reset_control_get(dev, NULL);
> Please use devm_reset_control_get_exclusive().

Well noted. Missed that, thanks.

Regards,
Rahul