From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44EC8C433E2 for ; Thu, 10 Sep 2020 09:00:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E2D7E206A1 for ; Thu, 10 Sep 2020 09:00:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730386AbgIJJA0 (ORCPT ); Thu, 10 Sep 2020 05:00:26 -0400 Received: from mx2.suse.de ([195.135.220.15]:59310 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729986AbgIJJAZ (ORCPT ); Thu, 10 Sep 2020 05:00:25 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id D9011AEC4; Thu, 10 Sep 2020 09:00:39 +0000 (UTC) Date: Thu, 10 Sep 2020 11:00:18 +0200 From: Oscar Salvador To: Vlastimil Babka Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Michal Hocko , Pavel Tatashin , David Hildenbrand , Joonsoo Kim Subject: Re: [RFC 2/5] mm, page_alloc: calculate pageset high and batch once per zone Message-ID: <20200910090018.GC2285@linux> References: <20200907163628.26495-1-vbabka@suse.cz> <20200907163628.26495-3-vbabka@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200907163628.26495-3-vbabka@suse.cz> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 07, 2020 at 06:36:25PM +0200, Vlastimil Babka wrote: > We currently call pageset_set_high_and_batch() for each possible cpu, > which repeats the same calculations of high and batch values. > > Instead call it once per zone, and it applies the calculated values > to all per-cpu pagesets of the zone. > > This also allows removing zone_pageset_init() and __zone_pcp_update() wrappers. > > No functional change. > > Signed-off-by: Vlastimil Babka I like this, it simplifies the things. Reviewed-by: Oscar Salvador -- Oscar Salvador SUSE L3