From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 408EDC433E2 for ; Thu, 10 Sep 2020 09:33:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0E70D20C09 for ; Thu, 10 Sep 2020 09:33:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730581AbgIJJdq (ORCPT ); Thu, 10 Sep 2020 05:33:46 -0400 Received: from mx2.suse.de ([195.135.220.15]:47998 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730356AbgIJJXL (ORCPT ); Thu, 10 Sep 2020 05:23:11 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id BBAEFAF47; Thu, 10 Sep 2020 09:23:25 +0000 (UTC) Date: Thu, 10 Sep 2020 11:23:07 +0200 From: Oscar Salvador To: Vlastimil Babka Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Michal Hocko , Pavel Tatashin , David Hildenbrand , Joonsoo Kim Subject: Re: [RFC 3/5] mm, page_alloc(): remove setup_pageset() Message-ID: <20200910092307.GD2285@linux> References: <20200907163628.26495-1-vbabka@suse.cz> <20200907163628.26495-4-vbabka@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200907163628.26495-4-vbabka@suse.cz> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 07, 2020 at 06:36:26PM +0200, Vlastimil Babka wrote: > We initialize boot-time pagesets with setup_pageset(), which sets high and > batch values that effectively disable pcplists. > > We can remove this wrapper if we just set these values for all pagesets in > pageset_init(). Non-boot pagesets then subsequently update them to specific > values. > > Signed-off-by: Vlastimil Babka Reviewed-by: Oscar Salvador Just one question below: > -static void setup_pageset(struct per_cpu_pageset *p) > -{ > - pageset_init(p); > - pageset_update(&p->pcp, 0, 1); > + /* > + * Set batch and high values safe for a boot pageset. Proper pageset's > + * initialization will update them. > + */ > + pcp->high = 0; > + pcp->batch = 1; pageset_update was manipulating these values with barriers in between. I guess we do not care here because we are not really updating but initializing them, right? -- Oscar Salvador SUSE L3