From: Kees Cook <keescook@chromium.org>
To: Elena Petrova <lenaptr@google.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: kernel-hardening@lists.openwall.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sched.h: drop in_ubsan field when UBSAN is in trap mode
Date: Thu, 10 Sep 2020 12:16:55 -0700 [thread overview]
Message-ID: <202009101216.1F173BD87D@keescook> (raw)
In-Reply-To: <20200910134802.3160311-1-lenaptr@google.com>
On Thu, Sep 10, 2020 at 02:48:02PM +0100, Elena Petrova wrote:
> in_ubsan field of task_struct is only used in lib/ubsan.c, which in its
> turn is used only `ifneq ($(CONFIG_UBSAN_TRAP),y)`.
>
> Removing unnecessary field from a task_struct will help preserve the
> ABI between vanilla and CONFIG_UBSAN_TRAP'ed kernels. In particular,
> this will help enabling bounds sanitizer transparently for Android's
> GKI.
>
> Signed-off-by: Elena Petrova <lenaptr@google.com>
Acked-by: Kees Cook <keescook@chromium.org>
(This should be CCed to akpm who has been taking most of the ubsan
patches lately.)
--
Kees Cook
next prev parent reply other threads:[~2020-09-10 19:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-10 13:48 [PATCH] sched.h: drop in_ubsan field when UBSAN is in trap mode Elena Petrova
2020-09-10 19:16 ` Kees Cook [this message]
2020-09-10 19:35 ` Jann Horn
2020-09-11 15:15 ` Elena Petrova
2020-09-11 16:22 ` Jann Horn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202009101216.1F173BD87D@keescook \
--to=keescook@chromium.org \
--cc=akpm@linux-foundation.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=lenaptr@google.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox