From: Bartosz Golaszewski <brgl@bgdev.pl>
To: Alessandro Zummo <a.zummo@towertech.it>,
Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org,
Bartosz Golaszewski <bgolaszewski@baylibre.com>
Subject: [PATCH v2 11/11] rtc: rx8010: use range checking provided by core RTC code
Date: Thu, 10 Sep 2020 15:04:46 +0200 [thread overview]
Message-ID: <20200910130446.5689-12-brgl@bgdev.pl> (raw)
In-Reply-To: <20200910130446.5689-1-brgl@bgdev.pl>
From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
We don't need to check the time range manually in set_time(), we can
use range_min and range_max exposed by struct rtc_device.
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
---
drivers/rtc/rtc-rx8010.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/rtc/rtc-rx8010.c b/drivers/rtc/rtc-rx8010.c
index 636e0de02d9b..e78f0808bdff 100644
--- a/drivers/rtc/rtc-rx8010.c
+++ b/drivers/rtc/rtc-rx8010.c
@@ -140,9 +140,6 @@ static int rx8010_set_time(struct device *dev, struct rtc_time *dt)
u8 date[RX8010_YEAR - RX8010_SEC + 1];
int err;
- if ((dt->tm_year < 100) || (dt->tm_year > 199))
- return -EINVAL;
-
/* set STOP bit before changing clock/calendar */
err = regmap_set_bits(rx8010->regs, RX8010_CTRL, RX8010_CTRL_STOP);
if (err)
@@ -415,6 +412,8 @@ static int rx8010_probe(struct i2c_client *client,
rx8010->rtc->ops = &rx8010_rtc_ops;
rx8010->rtc->max_user_freq = 1;
+ rx8010->rtc->range_min = RTC_TIMESTAMP_BEGIN_2000;
+ rx8010->rtc->range_max = RTC_TIMESTAMP_END_2099;
err = rtc_register_device(rx8010->rtc);
if (err) {
--
2.26.1
prev parent reply other threads:[~2020-09-10 21:40 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-10 13:04 [PATCH v2 00/11] rtc: rx8010: use regmap instead of i2c smbus API Bartosz Golaszewski
2020-09-10 13:04 ` [PATCH v2 01/11] rtc: rx8010: remove unnecessary brackets Bartosz Golaszewski
2020-09-10 13:04 ` [PATCH v2 02/11] rtc: rx8010: consolidate local variables of the same type Bartosz Golaszewski
2020-09-10 13:04 ` [PATCH v2 03/11] rtc: rx8010: use tabs instead of spaces for code formatting Bartosz Golaszewski
2020-09-10 13:04 ` [PATCH v2 04/11] rtc: rx8010: rename ret to err in rx8010_set_time() Bartosz Golaszewski
2020-09-10 13:04 ` [PATCH v2 05/11] rtc: rx8010: don't use magic values for time buffer length Bartosz Golaszewski
2020-09-10 13:04 ` [PATCH v2 06/11] rtc: rx8010: drop unnecessary initialization Bartosz Golaszewski
2020-09-10 13:04 ` [PATCH v2 07/11] rtc: rx8010: use a helper variable for client->dev in probe() Bartosz Golaszewski
2020-09-10 13:04 ` [PATCH v2 08/11] rtc: rx8010: prefer sizeof(*val) over sizeof(struct type_of_val) Bartosz Golaszewski
2020-09-10 13:04 ` [PATCH v2 09/11] rtc: rx8010: switch to using the preferred RTC API Bartosz Golaszewski
2020-09-11 12:33 ` Alexandre Belloni
2020-09-10 13:04 ` [PATCH v2 10/11] rtc: rx8010: convert to using regmap Bartosz Golaszewski
2020-09-10 13:04 ` Bartosz Golaszewski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200910130446.5689-12-brgl@bgdev.pl \
--to=brgl@bgdev.pl \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=bgolaszewski@baylibre.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox