Re: [PATCH rdma-next v1 3/4] lib/scatterlist: Add support in dynamic allocation of SG table from pages

Leon Romanovsky
2020-09-16T07:20:03Z

On Tue, Sep 15, 2020 at 06:23:39PM +0200, Christoph Hellwig wrote:
> > +#ifndef CONFIG_ARCH_NO_SG_CHAIN
> > +struct scatterlist *sg_alloc_table_append(
> > + struct sg_table *sgt, struct page **pages, unsigned int n_pages,
> > + unsigned int offset, unsigned long size, unsigned int max_segment,
> > + gfp_t gfp_mask, struct scatterlist *prv, unsigned int left_pages);
> > +#endif
>
> Odd indentation here, we either do two tabs (my preference) or aligned
> to the opening brace (what you seem to be doing elsewhere in the series).

All indentation came from clang-formatter, we will change.

Thanks