Re: [PATCH 03/14] XArray: docs: add missing kernel-doc parameters for xas_split_alloc()

Matthew Wilcox
2020-09-10T11:19:08Z

On Thu, Sep 10, 2020 at 12:23:56PM +0200, Mauro Carvalho Chehab wrote:
> /**
> - * Allocate memory for splitting an entry of @order size into the order
> - * stored in the @xas.
> + * xas_split_alloc() - Allocate memory for splitting an entry of
> + * @order size into the order stored in the @xas.
> + *
> + * @xas: is the 'xarray operation state'. It may be either a pointer to
> + * an xa_state, or an xa_state stored on the stack. This is an unfortunate
> + * ambiguity.
> + * @entry: refers to something stored in a slot in the xarray
> + * @order: size of each entry
> + * @gfp: GFP allocation flags
> */

No. I'll do this properly. Sorry for forgetting to document the arguments.

> void xas_split_alloc(struct xa_state *xas, void *entry, unsigned int order,
> gfp_t gfp)
> --
> 2.26.2
>