Re: [PATCH 13/15] habanalabs/gaudi: Add ethtool support using coresight

Oded Gabbay
2020-09-10T20:24:38Z

On Thu, Sep 10, 2020 at 11:19 PM Andrew Lunn <andrew@lunn.ch> wrote:
>
> > +static int gaudi_nic_get_link_ksettings(struct net_device *netdev,
> > + struct ethtool_link_ksettings *cmd)
> > +{
> > + struct gaudi_nic_device **ptr = netdev_priv(netdev);
> > + struct gaudi_nic_device *gaudi_nic = *ptr;
> > + struct hl_device *hdev = gaudi_nic->hdev;
> > + u32 port = gaudi_nic->port, speed = gaudi_nic->speed;
>
> Please go through the code and fixup Reverse Christmas tree.
Of course, we will fix this.

>
> > +
> > + cmd->base.speed = speed;
> > + cmd->base.duplex = DUPLEX_FULL;
> > +
> > + ethtool_link_ksettings_zero_link_mode(cmd, supported);
> > + ethtool_link_ksettings_zero_link_mode(cmd, advertising);
> > +
> > + ethtool_add_mode(cmd, supported, 100000baseCR4_Full);
> > + ethtool_add_mode(cmd, supported, 100000baseSR4_Full);
> > + ethtool_add_mode(cmd, supported, 100000baseKR4_Full);
> > + ethtool_add_mode(cmd, supported, 100000baseLR4_ER4_Full);
> > +
> > + ethtool_add_mode(cmd, supported, 50000baseSR2_Full);
> > + ethtool_add_mode(cmd, supported, 50000baseCR2_Full);
> > + ethtool_add_mode(cmd, supported, 50000baseKR2_Full);
> > +
> > + if (speed == SPEED_100000) {
> > + ethtool_add_mode(cmd, advertising, 100000baseCR4_Full);
> > + ethtool_add_mode(cmd, advertising, 100000baseSR4_Full);
> > + ethtool_add_mode(cmd, advertising, 100000baseKR4_Full);
> > + ethtool_add_mode(cmd, advertising, 100000baseLR4_ER4_Full);
> > +
> > + cmd->base.port = PORT_FIBRE;
> > +
> > + ethtool_add_mode(cmd, supported, FIBRE);
> > + ethtool_add_mode(cmd, advertising, FIBRE);
> > +
> > + ethtool_add_mode(cmd, supported, Backplane);
> > + ethtool_add_mode(cmd, advertising, Backplane);
> > + } else if (speed == SPEED_50000) {
> > + ethtool_add_mode(cmd, advertising, 50000baseSR2_Full);
> > + ethtool_add_mode(cmd, advertising, 50000baseCR2_Full);
> > + ethtool_add_mode(cmd, advertising, 50000baseKR2_Full);
> > + } else {
> > + dev_err(hdev->dev, "unknown speed %d, port %d\n", speed, port);
> > + return -EFAULT;
> > + }
> > +
> > + ethtool_add_mode(cmd, supported, Autoneg);
> > +
> > + if (gaudi_nic->auto_neg_enable) {
> > + ethtool_add_mode(cmd, advertising, Autoneg);
> > + cmd->base.autoneg = AUTONEG_ENABLE;
> > + if (gaudi_nic->auto_neg_resolved)
> > + ethtool_add_mode(cmd, lp_advertising, Autoneg);
> > + } else {
> > + cmd->base.autoneg = AUTONEG_DISABLE;
> > + }
> > +
> > + ethtool_add_mode(cmd, supported, Pause);
> > +
> > + if (gaudi_nic->pfc_enable)
> > + ethtool_add_mode(cmd, advertising, Pause);
> > +
> > + return 0;
> > +}
> > +
> > +static int gaudi_nic_set_link_ksettings(struct net_device *netdev,
> > + const struct ethtool_link_ksettings *cmd)
> > +{
> > + struct gaudi_nic_device **ptr = netdev_priv(netdev);
> > + struct gaudi_nic_device *gaudi_nic = *ptr;
> > + struct hl_device *hdev = gaudi_nic->hdev;
> > + u32 port = gaudi_nic->port;
> > + int rc = 0, speed = cmd->base.speed;
> > + bool auto_neg = cmd->base.autoneg == AUTONEG_ENABLE;
>
> It appears you only support speed and auto_neg. You should check that
> all other things which could be configured are empty, e.g. none of the
> bits are set in cmd->link_modes.advertising. If you are requested to
> configure something which is not supported, you need to return
> -EOPNOTSUPP.
>
> Andrew

Thanks Andrew,
We will do that and send an updated version.
Oded