Re: [PATCH v3 3/4] dt-bindings: i2c: imx: Add properties and use unevaluatedProperties

Rob Herring
2020-09-15T19:45:17Z

On Thu, Sep 10, 2020 at 08:22:43PM +0200, Krzysztof Kozlowski wrote:
> Additional properties actually might appear (e.g. power-domains) so
> describe all typical properties, reference generic i2c schema and use
> unevaluatedProperties to fix dtbs_check warnings like:
>
> arch/arm64/boot/dts/freescale/imx8mn-evk.dt.yaml: i2c@30a20000:
> '#address-cells', '#size-cells', 'pmic@25' do not match any of the regexes: 'pinctrl-[0-9]+'
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
>
> ---
>
> Changes since v2:
> 1. None
>
> Changes since v1:
> 1. Add more properties and include /schemas/i2c/i2c-controller.yaml#
> ---
> Documentation/devicetree/bindings/i2c/i2c-imx.yaml | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/i2c/i2c-imx.yaml b/Documentation/devicetree/bindings/i2c/i2c-imx.yaml
> index 810536953177..19c9daba6e9f 100644
> --- a/Documentation/devicetree/bindings/i2c/i2c-imx.yaml
> +++ b/Documentation/devicetree/bindings/i2c/i2c-imx.yaml
> @@ -9,6 +9,9 @@ title: Freescale Inter IC (I2C) and High Speed Inter IC (HS-I2C) for i.MX
> maintainers:
> - Wolfram Sang <wolfram@the-dreams.de>
>
> +allOf:
> + - $ref: /schemas/i2c/i2c-controller.yaml#
> +
> properties:
> compatible:
> oneOf:
> @@ -38,6 +41,9 @@ properties:
> - fsl,imx8mp-i2c
> - const: fsl,imx21-i2c
>
> + '#address-cells': true
> + '#size-cells': true

Drop these.

> +
> reg:
> maxItems: 1
>
> @@ -75,7 +81,7 @@ required:
> - interrupts
> - clocks
>
> -additionalProperties: false
> +unevaluatedProperties: false
>
> examples:
> - |
> --
> 2.17.1
>