Re: [PATCH v2 05/10] pwm: ntxec: Add driver for PWM function in Netronix EC

Andy Shevchenko
2020-09-08T08:48:23Z

On Tue, Sep 8, 2020 at 11:14 AM Lee Jones <lee.jones@linaro.org> wrote:
> On Sat, 05 Sep 2020, Andy Shevchenko wrote:
> > On Saturday, September 5, 2020, Jonathan Neuschäfer <j.neuschaefer@gmx.net>
> > wrote:

...

> > > +config PWM_NTXEC
> > > + tristate "Netronix embedded controller PWM support"
> >
> >
> >
> >
> > > + depends on MFD_NTXEC && OF
> >
> >
> > I don’t see need to reduce test coverage and use of the driver by sticking
> > with OF. Actually it’s not used.
>
> If the device is only known to boot with OF, then it's pointless
> building it when !OF.

No, it's not. As I pointed out the (compilation) test coverage is better.

> If you want to increase test coverage enable
> COMPILE_TEST instead.

It is one way to achieve that, yes;

depends on OF || COMPILE_TEST
depends on MFD_NTXEC

--
With Best Regards,
Andy Shevchenko