Re: [PATCH v2 05/10] pwm: ntxec: Add driver for PWM function in Netronix EC

Jonathan Neuschäfer
2020-09-10T19:17:30Z

[-- Attachment #1: Type: text/plain, Size: 1322 bytes --]

On Tue, Sep 08, 2020 at 10:35:38AM +0100, Lee Jones wrote:
> On Tue, 08 Sep 2020, Andy Shevchenko wrote:
>
> > On Tue, Sep 8, 2020 at 11:14 AM Lee Jones <lee.jones@linaro.org> wrote:
> > > On Sat, 05 Sep 2020, Andy Shevchenko wrote:
> > > > On Saturday, September 5, 2020, Jonathan Neuschäfer <j.neuschaefer@gmx.net>
[...]
> > > > > + depends on MFD_NTXEC && OF
> > > >
> > > >
> > > > I don’t see need to reduce test coverage and use of the driver by sticking
> > > > with OF. Actually it’s not used.
> > >
> > > If the device is only known to boot with OF, then it's pointless
> > > building it when !OF.
> >
> > No, it's not. As I pointed out the (compilation) test coverage is better.
>
> No, it's a waste of disk space.
>
> Why would you knowingly compile something you know you can't use?
>
> That's the whole point of COMPILE_TEST.
>
> Note that when you want real coverage and you use `allyesconfig`
> and/or `allmodconfig` then CONFIG_OF is also enabled on platforms
> which support it.
>
> > > If you want to increase test coverage enable
> > > COMPILE_TEST instead.
> >
> > It is one way to achieve that, yes;
> >
> > depends on OF || COMPILE_TEST
> > depends on MFD_NTXEC
>
> This is better.

Ok, I'll go with this variant.

Thanks

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]