[net-next v8 0/6] net: marvell: prestera: Add Switchdev driver for Prestera family ASIC device 98DX3255 (AC3x)

Vadym Kochan
2020-09-10T15:29:22Z

Marvell Prestera 98DX3255 integrates up to 24 ports of 1GbE with 8
ports of 10GbE uplinks or 2 ports of 40Gbps stacking for a largely
wireless SMB deployment.

Prestera Switchdev is a firmware based driver that operates via PCI bus. The
current implementation supports only boards designed for the Marvell Switchdev
solution and requires special firmware.

This driver implementation includes only L1, basic L2 support, and RX/TX.

The core Prestera switching logic is implemented in prestera_main.c, there is
an intermediate hw layer between core logic and firmware. It is
implemented in prestera_hw.c, the purpose of it is to encapsulate hw
related logic, in future there is a plan to support more devices with
different HW related configurations.

The following Switchdev features are supported:

- VLAN-aware bridge offloading
- VLAN-unaware bridge offloading
- FDB offloading (learning, ageing)
- Switchport configuration

The original firmware image is uploaded to the linux-firmware repository.

PATCH v8:
1) Put license in one line.

2) Sort includes.

3) Add missing comma for last enum member

4) Return original error code from last called func
in places where instead other error code was used.

5) Add comma for last member in initialized struct in prestera_hw.c

6) Do not initialize 'int err = 0' where it is not needed.

7) Simplify device-tree "marvell,prestera" node parsing by removing not
needed checking on 'np == NULL'.

8) Use u32p_replace_bits() instead of open-coded ((word & ~mask) | val)

9) Use dev_warn_ratelimited() instead of pr_warn_ratelimited to indicate the device
instance in prestera_rxtx.c

10) Simplify circular buffer list creation in prestera_sdma_{rx,tx}_init() by using
do { } while (prev != tail) construction.

11) Use MSEC_PER_SEC instead of hard-coded 1000.

12) Use traditional error handling pattern:

err = F();
if (err)
return err;

13) Use ether_addr_copy() instead of memcpy() for mac FDB copying in prestera_hw.c

14) Drop swdev->ageing_time member which is not used.

15) Fix ageing macro to be in ms instead of seconds.

Patches updated:
[1] net: marvell: prestera: Add driver for Prestera family ASIC devices
[2] net: marvell: prestera: Add PCI interface support
[3] net: marvell: prestera: Add basic devlink support
[4] net: marvell: prestera: Add ethtool interface support
[5] net: marvell: prestera: Add Switchdev driver implementation

PATCH v7:
1) Use ether_addr_copy() in prestera_main.c:prestera_port_set_mac_address()
instead of memcpy().

2) Removed not needed device's DMA address range check on
dma_pool_alloc() in prestera_rxtx.c:prestera_sdma_buf_init(),
this should be handled by dma_xxx() API considerig device's DMA mask.

3) Removed not needed device's DMA address range check on
dma_map_single() in prestera_rxtx.c:prestera_sdma_rx_skb_alloc(),
this should be handled by dma_xxx() API considerig device's DMA mask.

4) Add comment about port mac address limitation in the code where
it is used and checked - prestera_main.c:

- prestera_is_valid_mac_addr()
- prestera_port_create()

5) Add missing destroy_workqueue(swdev_wq) in prestera_switchdev.c:prestera_switchdev_init()
on error path handling.

Patches updated:
[1] net: marvell: prestera: Add driver for Prestera family ASIC devices
[5] net: marvell: prestera: Add Switchdev driver implementation

PATCH v6:
1) Use rwlock to protect port list on create/delete stages. The list
is mostly readable by fw event handler or packets receiver, but
updated only on create/delete port which are performed on switch init/fini
stages.

2) Remove not needed variable initialization in prestera_dsa.c:prestera_dsa_parse()

3) Get rid of bounce buffer used by tx handler in prestera_rxtx.c,
the bounce buffer should be handled by dma_xxx API via swiotlb.

4) Fix PRESTERA_SDMA_RX_DESC_PKT_LEN macro by using correct GENMASK(13, 0) in prestera_rxtx.c

Patches updated:
[1] net: marvell: prestera: Add driver for Prestera family ASIC devices

PATCH v5:
0) add Co-developed tags for people who was involved in development.

1) Make SPDX license as separate comment

2) Change 'u8 *' -> 'void *', It allows to avoid not-needed u8* casting.

3) Remove "," in terminated enum's.

4) Use GENMASK(end, start) where it is applicable in.

5) Remove not-needed 'u8 *' casting.

6) Apply common error-check pattern

7) Use ether_addr_copy instead of memcpy

8) Use define for maximum MAC address range (255)

9) Simplify prestera_port_state_set() in prestera_main.c by
using separate if-blocks for state setting:

if (is_up) {
...
} else {
...
}

which makes logic more understandable.

10) Simplify sdma tx wait logic when checking/updating tx_ring->burst.

11) Remove not-needed packed & aligned attributes

12) Use USEC_PER_MSEC as multiplier when converting ms -> usec on calling
readl_poll_timeout.

13) Simplified some error path handling by simple return error code in.

14) Remove not-needed err assignment in.

15) Use dev_err() in prestera_devlink_register(...).

Patches updated:
[1] net: marvell: prestera: Add driver for Prestera family ASIC devices
[2] net: marvell: prestera: Add PCI interface support
[3] net: marvell: prestera: Add basic devlink support
[4] net: marvell: prestera: Add ethtool interface support
[5] net: marvell: prestera: Add Switchdev driver implementation

PATCH v4:
1) Use prestera_ prefix in netdev_ops variable.

2) Kconfig: use 'default PRESTERA' build type for CONFIG_PRESTERA_PCI to be
synced by default with prestera core module.

3) Use memcpy_xxio helpers in prestera_pci.c for IO buffer copying.

4) Generate fw image path via snprintf() instead of macroses.

5) Use pcim_ helpers in prestera_pci.c which simplified the
probe/remove logic.

6) Removed not needed initializations of variables which are used in
readl_poll_xxx() helpers.

7) Fixed few grammar mistakes in patch[2] description.

8) Export only prestera_ethtool_ops struct instead of each
ethtool handler.

9) Add check for prestera_dev_check() in switchdev event handling to
make sure there is no wrong topology.

Patches updated:
[1] net: marvell: prestera: Add driver for Prestera family ASIC devices
[2] net: marvell: prestera: Add PCI interface support
[4] net: marvell: prestera: Add ethtool interface support
[5] net: marvell: prestera: Add Switchdev driver implementation

PATCH v3:
1) Simplify __be32 type casting in prestera_dsa.c

2) Added per-patch changelog under "---" line.

PATCH v2:
1) Use devlink_port_type_clear()

2) Add _MS prefix to timeout defines.

3) Remove not-needed packed attribute from the firmware ipc structs,
also the firmware image needs to be uploaded too (will do it soon).

4) Introduce prestera_hw_switch_fini(), to be mirrored with init and
do simple validation if the event handlers are unregistered.

5) Use kfree_rcu() for event handler unregistering.

6) Get rid of rcu-list usage when dealing with ports, not needed for
now.

7) Little spelling corrections in the error/info messages.

8) Make pci probe & remove logic mirrored.

9) Get rid of ETH_FCS_LEN in headroom setting, not needed.

PATCH:
1) Fixed W=1 warnings

2) Renamed PCI driver name to be more generic "Prestera DX" because
there will be more devices supported.

3) Changed firmware image dir path: marvell/ -> mrvl/prestera/
to be aligned with location in linux-firmware.git (if such
will be accepted).

RFC v3:
1) Fix prestera prefix in prestera_rxtx.c

2) Protect concurrent access from multiple ports on multiple CPU system
on tx path by spinlock in prestera_rxtx.c

3) Try to get base mac address from device-tree, otherwise use a random generated one.

4) Move ethtool interface support into separate prestera_ethtool.c file.

5) Add basic devlink support and get rid of physical port naming ops.

6) Add STP support in Switchdev driver.

7) Removed MODULE_AUTHOR

8) Renamed prestera.c -> prestera_main.c, and kernel module to
prestera.ko

RFC v2:
1) Use "pestera_" prefix in struct's and functions instead of mvsw_pr_

2) Original series split into additional patches for Switchdev ethtool support.

3) Use major and minor firmware version numbers in the firmware image filename.

4) Removed not needed prints.

5) Use iopoll API for waiting on register's value in prestera_pci.c

6) Use standart approach for describing PCI ID matching section instead of using
custom wrappers in prestera_pci.c

7) Add RX/TX support in prestera_rxtx.c.

8) Rewritten prestera_switchdev.c with following changes:
- handle netdev events from prestera.c

- use struct prestera_bridge for bridge objects, and get rid of
struct prestera_bridge_device which may confuse.

- use refcount_t

9) Get rid of macro usage for sending fw requests in prestera_hw.c

10) Add base_mac setting as module parameter. base_mac is required for
generation default port's mac.

Vadym Kochan (6):
net: marvell: prestera: Add driver for Prestera family ASIC devices
net: marvell: prestera: Add PCI interface support
net: marvell: prestera: Add basic devlink support
net: marvell: prestera: Add ethtool interface support
net: marvell: prestera: Add Switchdev driver implementation
dt-bindings: marvell,prestera: Add description for device-tree
bindings

.../bindings/net/marvell,prestera.txt | 34 +
drivers/net/ethernet/marvell/Kconfig | 1 +
drivers/net/ethernet/marvell/Makefile | 1 +
drivers/net/ethernet/marvell/prestera/Kconfig | 25 +
.../net/ethernet/marvell/prestera/Makefile | 7 +
.../net/ethernet/marvell/prestera/prestera.h | 206 +++
.../marvell/prestera/prestera_devlink.c | 112 ++
.../marvell/prestera/prestera_devlink.h | 23 +
.../ethernet/marvell/prestera/prestera_dsa.c | 104 ++
.../ethernet/marvell/prestera/prestera_dsa.h | 35 +
.../marvell/prestera/prestera_ethtool.c | 780 ++++++++++
.../marvell/prestera/prestera_ethtool.h | 11 +
.../ethernet/marvell/prestera/prestera_hw.c | 1253 ++++++++++++++++
.../ethernet/marvell/prestera/prestera_hw.h | 182 +++
.../ethernet/marvell/prestera/prestera_main.c | 663 +++++++++
.../ethernet/marvell/prestera/prestera_pci.c | 769 ++++++++++
.../ethernet/marvell/prestera/prestera_rxtx.c | 816 +++++++++++
.../ethernet/marvell/prestera/prestera_rxtx.h | 19 +
.../marvell/prestera/prestera_switchdev.c | 1277 +++++++++++++++++
.../marvell/prestera/prestera_switchdev.h | 13 +
20 files changed, 6331 insertions(+)
create mode 100644 drivers/net/ethernet/marvell/prestera/Kconfig
create mode 100644 drivers/net/ethernet/marvell/prestera/Makefile
create mode 100644 drivers/net/ethernet/marvell/prestera/prestera.h
create mode 100644 drivers/net/ethernet/marvell/prestera/prestera_devlink.c
create mode 100644 drivers/net/ethernet/marvell/prestera/prestera_devlink.h
create mode 100644 drivers/net/ethernet/marvell/prestera/prestera_dsa.c
create mode 100644 drivers/net/ethernet/marvell/prestera/prestera_dsa.h
create mode 100644 drivers/net/ethernet/marvell/prestera/prestera_ethtool.c
create mode 100644 drivers/net/ethernet/marvell/prestera/prestera_ethtool.h
create mode 100644 drivers/net/ethernet/marvell/prestera/prestera_hw.c
create mode 100644 drivers/net/ethernet/marvell/prestera/prestera_hw.h
create mode 100644 drivers/net/ethernet/marvell/prestera/prestera_main.c
create mode 100644 drivers/net/ethernet/marvell/prestera/prestera_pci.c
create mode 100644 drivers/net/ethernet/marvell/prestera/prestera_rxtx.c
create mode 100644 drivers/net/ethernet/marvell/prestera/prestera_rxtx.h
create mode 100644 drivers/net/ethernet/marvell/prestera/prestera_switchdev.c
create mode 100644 drivers/net/ethernet/marvell/prestera/prestera_switchdev.h

--
2.17.1