From: Andreas Kemnade <andreas@kemnade.info>
To: Tony Lindgren <tony@atomide.com>
Cc: khilman@kernel.org, linux@armlinux.org.uk,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, letux-kernel@openphoenux.org
Subject: Re: [PATCH] omap3: enable off mode automatically
Date: Fri, 11 Sep 2020 16:27:12 +0200 [thread overview]
Message-ID: <20200911162712.740d96ec@aktux> (raw)
In-Reply-To: <20200911103337.GH7101@atomide.com>
On Fri, 11 Sep 2020 13:33:37 +0300
Tony Lindgren <tony@atomide.com> wrote:
> * Andreas Kemnade <andreas@kemnade.info> [200911 09:50]:
> > --- a/arch/arm/mach-omap2/pm.h
> > +++ b/arch/arm/mach-omap2/pm.h
> > @@ -49,11 +49,7 @@ static inline int omap4_opp_init(void)
> > extern int omap3_pm_get_suspend_state(struct powerdomain *pwrdm);
> > extern int omap3_pm_set_suspend_state(struct powerdomain *pwrdm, int state);
> >
> > -#ifdef CONFIG_PM_DEBUG
> > extern u32 enable_off_mode;
> > -#else
> > -#define enable_off_mode 0
> > -#endif
>
> Hmm isn't the above still needed for the other SoCs? Or is omap3 the only
> user?
>
well, the linker moans about undefined symbols if
CONFIG_ARCH_OMAP3 is not enabled.
I will send a v2.
Regards,
Andreas
prev parent reply other threads:[~2020-09-11 16:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-11 6:49 [PATCH] omap3: enable off mode automatically Andreas Kemnade
2020-09-11 10:33 ` Tony Lindgren
2020-09-11 14:27 ` Andreas Kemnade [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200911162712.740d96ec@aktux \
--to=andreas@kemnade.info \
--cc=khilman@kernel.org \
--cc=letux-kernel@openphoenux.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox