From: peterz@infradead.org
To: Qais Yousef <qais.yousef@arm.com>
Cc: qianjun.kernel@gmail.com, tglx@linutronix.de, will@kernel.org,
luto@kernel.org, linux-kernel@vger.kernel.org,
laoar.shao@gmail.com, urezki@gmail.com,
John Dias <joaodias@google.com>, Wei Wang <wvw@google.com>,
Quentin Perret <qperret@google.com>
Subject: Re: [PATCH V6 1/1] Softirq:avoid large sched delay from the pending softirqs
Date: Fri, 11 Sep 2020 20:28:32 +0200 [thread overview]
Message-ID: <20200911182832.GL1362448@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20200911164644.eqjqjucvqfvrmr67@e107158-lin.cambridge.arm.com>
On Fri, Sep 11, 2020 at 05:46:45PM +0100, Qais Yousef wrote:
> On 09/09/20 17:09, qianjun.kernel@gmail.com wrote:
> > From: jun qian <qianjun.kernel@gmail.com>
> >
> > When get the pending softirqs, it need to process all the pending
> > softirqs in the while loop. If the processing time of each pending
> > softirq is need more than 2 msec in this loop, or one of the softirq
> > will running a long time, according to the original code logic, it
> > will process all the pending softirqs without wakeuping ksoftirqd,
> > which will cause a relatively large scheduling delay on the
> > corresponding CPU, which we do not wish to see. The patch will check
> > the total time to process pending softirq, if the time exceeds 2 ms
> > we need to wakeup the ksofirqd to aviod large sched delay.
> >
> > Signed-off-by: jun qian <qianjun.kernel@gmail.com>
>
> In Android there's a patch that tries to avoid schedling an RT task on a cpu
> that is running softirqs. I wonder if this patch helps with this case.
>
> https://android.googlesource.com/kernel/msm/+/5c3f54c34acf4d9ed01530288d4a98acff815d79%5E%21/#F0
>
> John, Wei, is this something of interest to you?
Urgh.. that's pretty gross. I think the sane approach is indeed getting
softirqs to react to need_resched() better.
next prev parent reply other threads:[~2020-09-11 18:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-09 9:09 [PATCH V6 1/1] Softirq:avoid large sched delay from the pending softirqs qianjun.kernel
2020-09-11 15:55 ` peterz
2020-09-12 7:17 ` jun qian
2020-09-11 16:46 ` Qais Yousef
2020-09-11 18:28 ` peterz [this message]
2020-09-14 11:27 ` Qais Yousef
2020-09-14 14:14 ` peterz
2020-09-14 15:28 ` Qais Yousef
[not found] ` <CA+njcd3HFV5Gqtt9qzTAzpnA4-4ngPBQ7T0gwgc0Fm9_VoJLcQ@mail.gmail.com>
2020-09-14 11:41 ` Qais Yousef
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200911182832.GL1362448@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=joaodias@google.com \
--cc=laoar.shao@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=qais.yousef@arm.com \
--cc=qianjun.kernel@gmail.com \
--cc=qperret@google.com \
--cc=tglx@linutronix.de \
--cc=urezki@gmail.com \
--cc=will@kernel.org \
--cc=wvw@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox