From: Christoph Hellwig <hch@lst.de>
To: Gabriel Krisman Bertazi <krisman@collabora.com>
Cc: luto@kernel.org, tglx@linutronix.de, hpa@zytor.com, bp@alien8.de,
rric@kernel.org, peterz@infradead.org, mingo@redhat.com,
x86@kernel.org, linux-kernel@vger.kernel.org,
kernel@collabora.com, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH 2/6] x86: Simplify compat syscall userspace allocation
Date: Sat, 12 Sep 2020 09:08:02 +0200 [thread overview]
Message-ID: <20200912070802.GA19621@lst.de> (raw)
In-Reply-To: <20200912070553.330622-3-krisman@collabora.com>
On Sat, Sep 12, 2020 at 03:05:49AM -0400, Gabriel Krisman Bertazi wrote:
> When allocating user memory space for a compat system call, don't
> consider whether the originating code is IA32 or X32, just allocate from
> a safe region for both, beyond the redzone. This should be safe for
> IA32, and has the benefit of avoiding TIF_IA32, which we want to drop.
This doesn't look wrong, by why bother (maybe Ccing me on the whole
seris as you always should instead of sending annoying out of context
single patches would have told..).
We will hopefully kill off compat_alloc_user_space in the next few
merge windows..
next prev parent reply other threads:[~2020-09-12 7:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-12 7:05 [PATCH 0/6] Prepare for removal of TIF_IA32 and TIF_X32 Gabriel Krisman Bertazi
2020-09-12 7:05 ` [PATCH 1/6] x86: events: Avoid TIF_IA32 when checking 64bit mode Gabriel Krisman Bertazi
2020-09-14 10:33 ` peterz
2020-09-12 7:05 ` [PATCH 2/6] x86: Simplify compat syscall userspace allocation Gabriel Krisman Bertazi
2020-09-12 7:08 ` Christoph Hellwig [this message]
2020-09-12 7:54 ` Gabriel Krisman Bertazi
2020-09-12 7:05 ` [PATCH 3/6] x86: oprofile: Avoid TIF_IA32 when checking 64bit mode Gabriel Krisman Bertazi
2020-09-12 7:05 ` [PATCH 4/6] x86: elf: Use e_machine to choose DLINFO in compat Gabriel Krisman Bertazi
2020-09-12 7:05 ` [PATCH 5/6] x86: elf: Use e_machine to select start_thread for x32 Gabriel Krisman Bertazi
2020-09-12 7:05 ` [PATCH 6/6] x86: elf: Use e_machine to select setup_additional_pages " Gabriel Krisman Bertazi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200912070802.GA19621@lst.de \
--to=hch@lst.de \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=kernel@collabora.com \
--cc=krisman@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rric@kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox