From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9C1BC43461 for ; Sat, 12 Sep 2020 07:08:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4F8B7214F1 for ; Sat, 12 Sep 2020 07:08:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725923AbgILHII (ORCPT ); Sat, 12 Sep 2020 03:08:08 -0400 Received: from verein.lst.de ([213.95.11.211]:39054 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725800AbgILHIG (ORCPT ); Sat, 12 Sep 2020 03:08:06 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id CC3BF68B02; Sat, 12 Sep 2020 09:08:02 +0200 (CEST) Date: Sat, 12 Sep 2020 09:08:02 +0200 From: Christoph Hellwig To: Gabriel Krisman Bertazi Cc: luto@kernel.org, tglx@linutronix.de, hpa@zytor.com, bp@alien8.de, rric@kernel.org, peterz@infradead.org, mingo@redhat.com, x86@kernel.org, linux-kernel@vger.kernel.org, kernel@collabora.com, Christoph Hellwig Subject: Re: [PATCH 2/6] x86: Simplify compat syscall userspace allocation Message-ID: <20200912070802.GA19621@lst.de> References: <20200912070553.330622-1-krisman@collabora.com> <20200912070553.330622-3-krisman@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200912070553.330622-3-krisman@collabora.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Sep 12, 2020 at 03:05:49AM -0400, Gabriel Krisman Bertazi wrote: > When allocating user memory space for a compat system call, don't > consider whether the originating code is IA32 or X32, just allocate from > a safe region for both, beyond the redzone. This should be safe for > IA32, and has the benefit of avoiding TIF_IA32, which we want to drop. This doesn't look wrong, by why bother (maybe Ccing me on the whole seris as you always should instead of sending annoying out of context single patches would have told..). We will hopefully kill off compat_alloc_user_space in the next few merge windows..