From: Greg KH <gregkh@linuxfoundation.org>
To: Anant Thazhemadam <anant.thazhemadam@gmail.com>
Cc: andriin@fb.com, ast@kernel.org, bpf@vger.kernel.org,
daniel@iogearbox.net, davem@davemloft.net, hawk@kernel.org,
john.fastabend@gmail.com, kafai@fb.com, kpsingh@chromium.org,
kuba@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Using a pointer and kzalloc in place of a struct directly
Date: Sat, 12 Sep 2020 16:55:25 +0200 [thread overview]
Message-ID: <20200912145525.GA769913@kroah.com> (raw)
In-Reply-To: <09477eb1-bbeb-74e8-eba9-d72cce6104db@gmail.com>
On Sat, Sep 12, 2020 at 05:43:38PM +0530, Anant Thazhemadam wrote:
>
> On 12/09/20 5:17 pm, Greg KH wrote:
> > Note, your "To:" line seemed corrupted, and why not cc: the bpf mailing
> > list as well?
> Oh, I'm sorry about that. I pulled the emails of all the people to whom
> this mail was sent off from the header in lkml mail, and just cc-ed
> everyone.
>
> > You leaked memory :(
> >
> > Did you test this patch? Where do you free this memory, I don't see
> > that happening anywhere in this patch, did I miss it?
>
> Yes, I did test this patch, which didn't seem to trigger any issues.
> It surprised me so much, that I ended up sending it in, to have
> it checked out.
You might not have noticed the memory leak if you were not looking for
it.
How did you test this?
> I wasn't sure where exactly the memory allocated here was
> supposed to be freed (might be why the current implementation
> isn't exactly using kzalloc). I forgot to mention it in the initial mail,
> and I was hoping that someone would point me in the right direction
> (if this approach was actually going to be considered, that is, which in
> retrospect I now feel might not be the best thing)
It has to be freed somewhere, you wrote the patch :)
But back to the original question here, why do you feel this change is
needed? What does this do better/faster/more correct than the code that
is currently there? Unless you can provide that, the change should not
be needed, right?
thanks,
greg k-h
next prev parent reply other threads:[~2020-09-12 15:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-10 9:29 WARNING in bpf_raw_tp_link_fill_link_info syzbot
2020-09-10 22:00 ` Andrii Nakryiko
2020-10-30 10:09 ` Dmitry Vyukov
2020-09-12 11:38 ` [PATCH] Using a pointer and kzalloc in place of a struct directly Anant Thazhemadam
2020-09-12 11:47 ` Greg KH
2020-09-12 12:13 ` Anant Thazhemadam
2020-09-12 14:55 ` Greg KH [this message]
2020-09-12 20:02 ` Anant Thazhemadam
2020-09-13 11:49 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200912145525.GA769913@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=anant.thazhemadam@gmail.com \
--cc=andriin@fb.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=hawk@kernel.org \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=kpsingh@chromium.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox