Re: [PATCH 1/4] dt-bindings: fsl: add i.MX7ULP PMC binding doc

Shawn Guo
2020-09-13T02:50:40Z

On Fri, Sep 11, 2020 at 07:45:20AM +0000, Peng Fan wrote:
> > b/Documentation/devicetree/bindings/arm/freescale/imx7ulp-pmc.yaml
> > > @@ -0,0 +1,33 @@
> > > +# SPDX-License-Identifier: GPL-2.0
> > > +%YAML 1.2
> > > +---
> > > +$id: http://devicetree.org/schemas/arm/freescale/imx7ulp-pmc.yaml#
> > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > +
> > > +title: i.MX7ULP Power Management Controller(PMC) Device Tree Bindings
> > > +
> > > +maintainers:
> > > + - Peng Fan <peng.fan@nxp.com>
> > > +
> > > +properties:
> > > + compatible:
> > > + items:
> > > + - enum:
> > > + - fsl,imx7ulp-pmc-m4
> > > + - fsl,imx7ulp-pmc-a7
> >
> > Can we change to the exist naming pattern which also align with HW
> > reference manual?
> > e.g.
> > fsl,imx7ulp-pmc0
> > fsl,imx7ulp-pmc1
>
> This was rejected by Shawn before.
> https://patchwork.kernel.org/patch/11390591/

Oh, I'm fine with the naming if pmc0 and pmc1 are different HW block
rather than two instances of the same block.

Shawn