From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Jason Yan <yanaijie@huawei.com>
Cc: agross@kernel.org, mturquette@baylibre.com, sboyd@kernel.org,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org, Hulk Robot <hulkci@huawei.com>
Subject: Re: [PATCH] clk: qcom: gcc-msm8939: remove defined but not used variables
Date: Sat, 12 Sep 2020 23:00:48 -0500 [thread overview]
Message-ID: <20200913040048.GW3715@yoga> (raw)
In-Reply-To: <20200911013722.1459387-1-yanaijie@huawei.com>
On Thu 10 Sep 20:37 CDT 2020, Jason Yan wrote:
> This addresses the following gcc warning with "make W=1":
>
> drivers/clk/qcom/gcc-msm8939.c:610:32: warning:
> ‘gcc_xo_gpll6_gpll0a_map’ defined but not used
> [-Wunused-const-variable=]
> static const struct parent_map gcc_xo_gpll6_gpll0a_map[] = {
> ^~~~~~~~~~~~~~~~~~~~~~~
> drivers/clk/qcom/gcc-msm8939.c:598:32: warning: ‘gcc_xo_gpll6_gpll0_map’
> defined but not used [-Wunused-const-variable=]
> static const struct parent_map gcc_xo_gpll6_gpll0_map[] = {
> ^~~~~~~~~~~~~~~~~~~~~~
>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
> ---
> drivers/clk/qcom/gcc-msm8939.c | 12 ------------
> 1 file changed, 12 deletions(-)
>
> diff --git a/drivers/clk/qcom/gcc-msm8939.c b/drivers/clk/qcom/gcc-msm8939.c
> index 778354f82b1e..39ebb443ae3d 100644
> --- a/drivers/clk/qcom/gcc-msm8939.c
> +++ b/drivers/clk/qcom/gcc-msm8939.c
> @@ -595,24 +595,12 @@ static const struct clk_parent_data gcc_xo_gpll1_emclk_sleep_parent_data[] = {
> { .fw_name = "sleep_clk", .name = "sleep_clk" },
> };
>
> -static const struct parent_map gcc_xo_gpll6_gpll0_map[] = {
> - { P_XO, 0 },
> - { P_GPLL6, 1 },
> - { P_GPLL0, 2 },
> -};
> -
> static const struct clk_parent_data gcc_xo_gpll6_gpll0_parent_data[] = {
> { .fw_name = "xo" },
> { .hw = &gpll6_vote.hw },
> { .hw = &gpll0_vote.hw },
> };
>
> -static const struct parent_map gcc_xo_gpll6_gpll0a_map[] = {
> - { P_XO, 0 },
> - { P_GPLL6, 1 },
> - { P_GPLL0_AUX, 2 },
> -};
> -
> static const struct clk_parent_data gcc_xo_gpll6_gpll0a_parent_data[] = {
> { .fw_name = "xo" },
> { .hw = &gpll6_vote.hw },
> --
> 2.25.4
>
next prev parent reply other threads:[~2020-09-13 4:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-11 1:37 [PATCH] clk: qcom: gcc-msm8939: remove defined but not used variables Jason Yan
2020-09-13 4:00 ` Bjorn Andersson [this message]
2020-09-22 18:50 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200913040048.GW3715@yoga \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=hulkci@huawei.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
--cc=yanaijie@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox