From: Dominique Martinet <asmadeus@codewreck.org>
To: Jianyong Wu <jianyong.wu@arm.com>
Cc: lucho@ionkov.net, justin.he@arm.com, ericvh@gmail.com,
linux-kernel@vger.kernel.org,
v9fs-developer@lists.sourceforge.net, Greg Kurz <groug@kaod.org>
Subject: Re: [V9fs-developer] [PATCH RFC 4/4] 9p: fix race issue in fid contention.
Date: Mon, 14 Sep 2020 08:31:43 +0200 [thread overview]
Message-ID: <20200914063143.GA19326@nautica> (raw)
In-Reply-To: <20200914055535.GA30672@nautica>
Dominique Martinet wrote on Mon, Sep 14, 2020:
> Jianyong Wu wrote on Mon, Sep 14, 2020:
> - Ideally base yourself of my 9p-test branch to have async clunk:
> https://github.com/martinetd/linux/commits/9p-test
> I've been promising to push it to next this week™ for a couple of weeks
> but if something is based on it I won't be able to delay this much
> longer, it'll get pushed to 5.10 cycle anyway.
> (I'll resend the patches to be clean)
>
>> tests:
>> race issue test from the old test case:
>> for file in {01..50}; do touch f.${file}; done
>> seq 1 1000 | xargs -n 1 -P 50 -I{} cat f.* > /dev/null
hmpf, so that made me insist a bit on this test on my patch and I see
a problem with that as well. The me from a few years ago was good!
With that said I'll want to work a bit more on this, so feel free to
base off master and I'll deal with rebase if required.
Part of me thinks it's the same bug that will be fixed with refcounting
and I just made it easier to hit, but I'm honestly unsure at this point
and testing would basically mean I just code what I asked you to...
Well, let me know if you want me to do the refcounting, but I'd rather
let you finish what you started. If possible put the patch first in the
series so commits can be tested independently.
Thanks,
--
Dominique
next prev parent reply other threads:[~2020-09-14 6:32 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-14 3:37 [PATCH RFC 0/4] 9p: fix open-unlink-f*syscall bug Jianyong Wu
2020-09-14 3:37 ` [PATCH RFC 1/4] fs/9p: fix create-unlink-getattr idiom Jianyong Wu
2020-09-14 6:00 ` Dominique Martinet
2020-09-14 8:11 ` Greg Kurz
2020-09-14 3:37 ` [PATCH RFC 2/4] fs/9p: track open fids Jianyong Wu
2020-09-14 3:37 ` [PATCH RFC 3/4] fs/9p: search open fids first Jianyong Wu
2020-09-14 3:37 ` [PATCH RFC 4/4] 9p: fix race issue in fid contention Jianyong Wu
2020-09-14 5:55 ` Dominique Martinet
2020-09-14 6:31 ` Dominique Martinet [this message]
2020-09-14 7:50 ` [V9fs-developer] " Jianyong Wu
2020-09-14 7:32 ` Jianyong Wu
2020-09-14 8:32 ` Dominique Martinet
2020-09-14 12:34 ` Jianyong Wu
2020-09-18 8:57 ` Jianyong Wu
2020-09-18 9:34 ` Dominique Martinet
2020-09-18 10:05 ` Jianyong Wu
2020-09-14 8:35 ` [V9fs-developer] [PATCH RFC 0/4] 9p: fix open-unlink-f*syscall bug Greg Kurz
2020-09-14 11:06 ` Christian Schoenebeck
2020-09-14 12:43 ` Greg Kurz
2020-09-14 15:19 ` Christian Schoenebeck
2020-09-14 15:46 ` Greg Kurz
2020-09-16 12:16 ` Greg Kurz
2020-09-17 10:07 ` Christian Schoenebeck
2020-09-14 12:36 ` Jianyong Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200914063143.GA19326@nautica \
--to=asmadeus@codewreck.org \
--cc=ericvh@gmail.com \
--cc=groug@kaod.org \
--cc=jianyong.wu@arm.com \
--cc=justin.he@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lucho@ionkov.net \
--cc=v9fs-developer@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox