From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Johnny Chuang <johnny.chuang.emc@gmail.com>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>,
Peter Hutterer <peter.hutterer@who-t.net>,
linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
Harry Cutts <hcutts@chromium.org>,
Johnny Chuang <johnny.chuang@emc.com.tw>,
James Chen <james.chen@emc.com.tw>,
Jennifer Tsai <jennifer.tsai@emc.com.tw>,
Paul Liang <paul.liang@emc.com.tw>,
Jeff Chuang <jeff.chuang@emc.com.tw>
Subject: Re: [PATCH v3] Input: elants_i2c - Report resolution of ABS_MT_TOUCH_MAJOR by FW information.
Date: Sun, 13 Sep 2020 23:41:48 -0700 [thread overview]
Message-ID: <20200914064148.GQ1665100@dtor-ws> (raw)
In-Reply-To: <1598581195-9874-1-git-send-email-johnny.chuang.emc@gmail.com>
On Fri, Aug 28, 2020 at 10:19:55AM +0800, Johnny Chuang wrote:
> This patch adds a new behavior to report touch major resolution
> based on information provided by firmware.
>
> In initial process, driver acquires touch information from touch ic.
> It contains one byte about the resolution value of ABS_MT_TOUCH_MAJOR.
> Touch driver will report touch major resolution by this information.
>
> Signed-off-by: Johnny Chuang <johnny.chuang.emc@gmail.com>
> ---
> Changes in v2:
> - register a real resolution value from firmware,
> instead of hardcoding resolution value as 1 by flag.
> Changes in v3:
> - modify git log message from flag to real value.
> - modify driver comment from flag to real value.
> ---
> drivers/input/touchscreen/elants_i2c.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/input/touchscreen/elants_i2c.c b/drivers/input/touchscreen/elants_i2c.c
> index b0bd5bb..661a3ee 100644
> --- a/drivers/input/touchscreen/elants_i2c.c
> +++ b/drivers/input/touchscreen/elants_i2c.c
> @@ -151,6 +151,7 @@ struct elants_data {
>
> bool wake_irq_enabled;
> bool keep_power_in_suspend;
> + u8 report_major_resolution;
I renamed this to "major_res" to match x_res and y_res, and applied.
Thanks.
--
Dmitry
prev parent reply other threads:[~2020-09-14 6:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-28 2:19 [PATCH v3] Input: elants_i2c - Report resolution of ABS_MT_TOUCH_MAJOR by FW information Johnny Chuang
2020-08-28 17:42 ` Harry Cutts
2020-09-14 3:39 ` Johnny.Chuang
2020-09-14 6:41 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200914064148.GQ1665100@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=benjamin.tissoires@redhat.com \
--cc=hcutts@chromium.org \
--cc=james.chen@emc.com.tw \
--cc=jeff.chuang@emc.com.tw \
--cc=jennifer.tsai@emc.com.tw \
--cc=johnny.chuang.emc@gmail.com \
--cc=johnny.chuang@emc.com.tw \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paul.liang@emc.com.tw \
--cc=peter.hutterer@who-t.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox