From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EED65C43461 for ; Mon, 14 Sep 2020 09:00:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A91DB207C3 for ; Mon, 14 Sep 2020 09:00:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726241AbgINJAB (ORCPT ); Mon, 14 Sep 2020 05:00:01 -0400 Received: from mx2.suse.de ([195.135.220.15]:60302 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726112AbgINI7z (ORCPT ); Mon, 14 Sep 2020 04:59:55 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 3C5D9AC46; Mon, 14 Sep 2020 09:00:09 +0000 (UTC) Date: Mon, 14 Sep 2020 10:59:53 +0200 From: Michal Hocko To: Laurent Dufour Cc: akpm@linux-foundation.org, David Hildenbrand , Oscar Salvador , Greg Kroah-Hartman , linux-mm@kvack.org, "Rafael J . Wysocki" , nathanl@linux.ibm.com, cheloha@linux.ibm.com, Tony Luck , Fenghua Yu , linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] mm: replace memmap_context by memplug_context Message-ID: <20200914085953.GD16999@dhcp22.suse.cz> References: <20200911134831.53258-1-ldufour@linux.ibm.com> <20200911134831.53258-2-ldufour@linux.ibm.com> <20200914084904.GA16999@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon 14-09-20 10:51:06, Laurent Dufour wrote: > Le 14/09/2020 à 10:49, Michal Hocko a écrit : [...] > > /* > > * Memory initialization context, use to differentiate memory added by > > * the platform statically or via memory hotplug interface. > > */ > > enum meminit_context { > > MEMINIT_EARLY, > > MEMINIT_HOTPLUG > > } > > > > Sounds good too. > What about its definition's place, in include/mm/zone.h as David suggested ? Yes. This shouldn't be in the hotplug proper. -- Michal Hocko SUSE Labs