From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED202C433E2 for ; Mon, 14 Sep 2020 14:45:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AB09E205F4 for ; Mon, 14 Sep 2020 14:45:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600094726; bh=C87FEcxOQvwbve5njzgtcQ3YGHj3Yux44IZWafvgDVk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=mQJUio+aEj8f17sRjwCejXQ/Aokx1eBvie5L/g3atUVnjAyX7lzFDzNdYHaPMdIBs VnO4THUhlqCDuu7CMPnrqb0X7ZD8f0JLD6UztbIYXZwdnIhh4FAXBMR6bEp6UabWjD l8xn+49uU0nhy2KISuHFAg2KbTsCUTlI18bZoqrU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726803AbgINOpU (ORCPT ); Mon, 14 Sep 2020 10:45:20 -0400 Received: from mail.kernel.org ([198.145.29.99]:60294 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726635AbgINNFm (ORCPT ); Mon, 14 Sep 2020 09:05:42 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C57B121973; Mon, 14 Sep 2020 13:04:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600088690; bh=C87FEcxOQvwbve5njzgtcQ3YGHj3Yux44IZWafvgDVk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=FPveibCtGLl3xKhbztRtS06wXlr4S6P3ujvy9nkF+pjbqBZ7yQ/hqMuX156G8tH2/ AY7pmtvmiuR3L5xCsCJN1M5ZKCZoWDadUleLvQJEufak/SaJpdXv7fkNyBpqONsqL3 KkOcGradHBe5SBdRyjOxMAACYH19+pr4xxCpw8GE= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: David Milburn , Keith Busch , Sagi Grimberg , Christoph Hellwig , Sasha Levin , linux-nvme@lists.infradead.org Subject: [PATCH AUTOSEL 5.4 13/22] nvme-fc: cancel async events before freeing event struct Date: Mon, 14 Sep 2020 09:04:25 -0400 Message-Id: <20200914130434.1804478-13-sashal@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200914130434.1804478-1-sashal@kernel.org> References: <20200914130434.1804478-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: David Milburn [ Upstream commit e126e8210e950bb83414c4f57b3120ddb8450742 ] Cancel async event work in case async event has been queued up, and nvme_fc_submit_async_event() runs after event has been freed. Signed-off-by: David Milburn Reviewed-by: Keith Busch Reviewed-by: Sagi Grimberg Signed-off-by: Christoph Hellwig Signed-off-by: Sasha Levin --- drivers/nvme/host/fc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/nvme/host/fc.c b/drivers/nvme/host/fc.c index dce4d6782ceb1..dae050d1f814d 100644 --- a/drivers/nvme/host/fc.c +++ b/drivers/nvme/host/fc.c @@ -1820,6 +1820,7 @@ nvme_fc_term_aen_ops(struct nvme_fc_ctrl *ctrl) struct nvme_fc_fcp_op *aen_op; int i; + cancel_work_sync(&ctrl->ctrl.async_event_work); aen_op = ctrl->aen_ops; for (i = 0; i < NVME_NR_AEN_COMMANDS; i++, aen_op++) { if (!aen_op->fcp_req.private) -- 2.25.1