From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A48CC43461 for ; Mon, 14 Sep 2020 14:48:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 45F3B207EA for ; Mon, 14 Sep 2020 14:48:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600094930; bh=UKno+OfoKWcMw03cOeLGzo/sZOEDnGfMcq5uX14k7HI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=W9iVsjqSwb4K7Kchrl2uNpzYFF3YFSKESLCsleRZc5rdzdm1VK0T4RR30dcv4/E3T QXIKjLNrTPIrJH0MI8u5xKbtQnBpb/r5ks8l5tfGmXDuaWFbwqyYUAt3Ls5XrMbLxx PlNPA3dH0YAc2Ppbnfp0d/cxeZQQvv1E/VAaeaYE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726822AbgINOsZ (ORCPT ); Mon, 14 Sep 2020 10:48:25 -0400 Received: from mail.kernel.org ([198.145.29.99]:60114 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726634AbgINNFm (ORCPT ); Mon, 14 Sep 2020 09:05:42 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 671E62223C; Mon, 14 Sep 2020 13:04:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600088686; bh=UKno+OfoKWcMw03cOeLGzo/sZOEDnGfMcq5uX14k7HI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=nVfBmeO2FqMo05woFy5Es2MmrzGB3zqc0tjuBFDwO0hjgNxKv96mxU8dWyfdZdJOj JlrlNoAZmNMxPM9STRCy24qhqwsn216nra+aoEIR6Y/H5R0ROLRSmJAUY2P+QG3hqe D9k0ESQjLAGmD9HR/PegoigDednRHF/9zdRgC470= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Laurent Pinchart , Randy Dunlap , Sasha Levin Subject: [PATCH AUTOSEL 5.4 09/22] rapidio: Replace 'select' DMAENGINES 'with depends on' Date: Mon, 14 Sep 2020 09:04:21 -0400 Message-Id: <20200914130434.1804478-9-sashal@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200914130434.1804478-1-sashal@kernel.org> References: <20200914130434.1804478-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Laurent Pinchart [ Upstream commit d2b86100245080cfdf1e95e9e07477474c1be2bd ] Enabling a whole subsystem from a single driver 'select' is frowned upon and won't be accepted in new drivers, that need to use 'depends on' instead. Existing selection of DMAENGINES will then cause circular dependencies. Replace them with a dependency. Signed-off-by: Laurent Pinchart Acked-by: Randy Dunlap Signed-off-by: Sasha Levin --- drivers/rapidio/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rapidio/Kconfig b/drivers/rapidio/Kconfig index 677d1aff61b7f..788e7830771be 100644 --- a/drivers/rapidio/Kconfig +++ b/drivers/rapidio/Kconfig @@ -37,7 +37,7 @@ config RAPIDIO_ENABLE_RX_TX_PORTS config RAPIDIO_DMA_ENGINE bool "DMA Engine support for RapidIO" depends on RAPIDIO - select DMADEVICES + depends on DMADEVICES select DMA_ENGINE help Say Y here if you want to use DMA Engine frameork for RapidIO data -- 2.25.1