From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Stafford Horne <shorne@gmail.com>,
Sasha Levin <sashal@kernel.org>,
openrisc@lists.librecores.org
Subject: [PATCH AUTOSEL 4.19 11/19] openrisc: Fix cache API compile issue when not inlining
Date: Mon, 14 Sep 2020 09:04:54 -0400 [thread overview]
Message-ID: <20200914130502.1804708-11-sashal@kernel.org> (raw)
In-Reply-To: <20200914130502.1804708-1-sashal@kernel.org>
From: Stafford Horne <shorne@gmail.com>
[ Upstream commit 3ae90d764093dfcd6ab8ab6875377302892c87d4 ]
I found this when compiling a kbuild random config with GCC 11. The
config enables CONFIG_DEBUG_SECTION_MISMATCH, which sets CFLAGS
-fno-inline-functions-called-once. This causes the call to cache_loop in
cache.c to not be inlined causing the below compile error.
In file included from arch/openrisc/mm/cache.c:13:
arch/openrisc/mm/cache.c: In function 'cache_loop':
./arch/openrisc/include/asm/spr.h:16:27: warning: 'asm' operand 0 probably does not match constraints
16 | #define mtspr(_spr, _val) __asm__ __volatile__ ( \
| ^~~~~~~
arch/openrisc/mm/cache.c:25:3: note: in expansion of macro 'mtspr'
25 | mtspr(reg, line);
| ^~~~~
./arch/openrisc/include/asm/spr.h:16:27: error: impossible constraint in 'asm'
16 | #define mtspr(_spr, _val) __asm__ __volatile__ ( \
| ^~~~~~~
arch/openrisc/mm/cache.c:25:3: note: in expansion of macro 'mtspr'
25 | mtspr(reg, line);
| ^~~~~
make[1]: *** [scripts/Makefile.build:283: arch/openrisc/mm/cache.o] Error 1
The asm constraint "K" requires a immediate constant argument to mtspr,
however because of no inlining a register argument is passed causing a
failure. Fix this by using __always_inline.
Link: https://lore.kernel.org/lkml/202008200453.ohnhqkjQ%25lkp@intel.com/
Signed-off-by: Stafford Horne <shorne@gmail.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
arch/openrisc/mm/cache.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/openrisc/mm/cache.c b/arch/openrisc/mm/cache.c
index b747bf1fc1b63..4272d9123f9ed 100644
--- a/arch/openrisc/mm/cache.c
+++ b/arch/openrisc/mm/cache.c
@@ -20,7 +20,7 @@
#include <asm/cacheflush.h>
#include <asm/tlbflush.h>
-static void cache_loop(struct page *page, const unsigned int reg)
+static __always_inline void cache_loop(struct page *page, const unsigned int reg)
{
unsigned long paddr = page_to_pfn(page) << PAGE_SHIFT;
unsigned long line = paddr & ~(L1_CACHE_BYTES - 1);
--
2.25.1
next prev parent reply other threads:[~2020-09-14 14:31 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-14 13:04 [PATCH AUTOSEL 4.19 01/19] NFSv4.1 handle ERR_DELAY error reclaiming locking state on delegation recall Sasha Levin
2020-09-14 13:04 ` [PATCH AUTOSEL 4.19 02/19] scsi: pm8001: Fix memleak in pm8001_exec_internal_task_abort Sasha Levin
2020-09-14 13:04 ` [PATCH AUTOSEL 4.19 03/19] scsi: libfc: Fix for double free() Sasha Levin
2020-09-14 13:04 ` [PATCH AUTOSEL 4.19 04/19] scsi: lpfc: Fix FLOGI/PLOGI receive race condition in pt2pt discovery Sasha Levin
2020-09-14 13:04 ` [PATCH AUTOSEL 4.19 05/19] regulator: pwm: Fix machine constraints application Sasha Levin
2020-09-14 13:04 ` [PATCH AUTOSEL 4.19 06/19] spi: spi-loopback-test: Fix out-of-bounds read Sasha Levin
2020-09-14 13:04 ` [PATCH AUTOSEL 4.19 07/19] NFS: Zero-stateid SETATTR should first return delegation Sasha Levin
2020-09-14 13:04 ` [PATCH AUTOSEL 4.19 08/19] SUNRPC: stop printk reading past end of string Sasha Levin
2020-09-14 13:04 ` [PATCH AUTOSEL 4.19 09/19] rapidio: Replace 'select' DMAENGINES 'with depends on' Sasha Levin
2020-09-14 13:04 ` [PATCH AUTOSEL 4.19 10/19] kobject: Drop unneeded conditional in __kobject_del() Sasha Levin
2020-09-14 13:04 ` Sasha Levin [this message]
2020-09-14 13:04 ` [PATCH AUTOSEL 4.19 12/19] nvme-fc: cancel async events before freeing event struct Sasha Levin
2020-09-14 13:04 ` [PATCH AUTOSEL 4.19 13/19] nvme-rdma: " Sasha Levin
2020-09-14 13:04 ` [PATCH AUTOSEL 4.19 14/19] f2fs: fix indefinite loop scanning for free nid Sasha Levin
2020-09-14 13:04 ` [PATCH AUTOSEL 4.19 15/19] f2fs: Return EOF on unaligned end of file DIO read Sasha Levin
2020-09-14 13:04 ` [PATCH AUTOSEL 4.19 16/19] i2c: algo: pca: Reapply i2c bus settings after reset Sasha Levin
2020-09-14 13:05 ` [PATCH AUTOSEL 4.19 17/19] spi: Fix memory leak on splited transfers Sasha Levin
2020-09-14 13:05 ` [PATCH AUTOSEL 4.19 18/19] gcov: add support for GCC 10.1 Sasha Levin
2020-09-14 13:05 ` [PATCH AUTOSEL 4.19 19/19] KVM: MIPS: Change the definition of kvm type Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200914130502.1804708-11-sashal@kernel.org \
--to=sashal@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=openrisc@lists.librecores.org \
--cc=shorne@gmail.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox