From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D596BC433E2 for ; Mon, 14 Sep 2020 13:25:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 84BE0206B8 for ; Mon, 14 Sep 2020 13:25:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600089939; bh=drZYiRmwOVUnvr3J1YCJlIMxqcOH5GZK3mbze+Ex65E=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=0WsvTqBPyAvhwy6NF1dE3dsrdk8KQZY/7RUO3Ci3zyT2bwRPfeRRDItZlUQeknBvv kCU7gLjwHYalSSFq/TPYa7W4Zh2XdztdvDesUcrF/dL6i5FW6NFay+esj3rB7d5RvH yroh1cjPmXEEp7e9Y3c/BLlPfNTSgZHCe2atuAzQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726540AbgINNZZ (ORCPT ); Mon, 14 Sep 2020 09:25:25 -0400 Received: from mail.kernel.org ([198.145.29.99]:60114 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726706AbgINNHO (ORCPT ); Mon, 14 Sep 2020 09:07:14 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8BCB722228; Mon, 14 Sep 2020 13:06:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600088762; bh=drZYiRmwOVUnvr3J1YCJlIMxqcOH5GZK3mbze+Ex65E=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=OP7zlv7kZNpyJX6BXzjkWE8RHm4Y6iHSFpRmYoKAdIJ0V4NO93yz25RulFpiL0z// t0H1e/lIL8DYPSdwBwANG+lP2/iPRxiprEK50UPhKxBsn6VaQ6uvlyU3/e8WD4WmzJ kQPLUpyJLJ8uFH8Uk33N/duwazniANVBURxTRRIc= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Dinghao Liu , Jack Wang , "Martin K . Petersen" , Sasha Levin , linux-scsi@vger.kernel.org Subject: [PATCH AUTOSEL 4.4 2/8] scsi: pm8001: Fix memleak in pm8001_exec_internal_task_abort Date: Mon, 14 Sep 2020 09:05:52 -0400 Message-Id: <20200914130559.1805574-2-sashal@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200914130559.1805574-1-sashal@kernel.org> References: <20200914130559.1805574-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dinghao Liu [ Upstream commit ea403fde7552bd61bad6ea45e3feb99db77cb31e ] When pm8001_tag_alloc() fails, task should be freed just like it is done in the subsequent error paths. Link: https://lore.kernel.org/r/20200823091453.4782-1-dinghao.liu@zju.edu.cn Acked-by: Jack Wang Signed-off-by: Dinghao Liu Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/pm8001/pm8001_sas.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/pm8001/pm8001_sas.c b/drivers/scsi/pm8001/pm8001_sas.c index 3862d8b1defe3..ee6c941123e10 100644 --- a/drivers/scsi/pm8001/pm8001_sas.c +++ b/drivers/scsi/pm8001/pm8001_sas.c @@ -792,7 +792,7 @@ pm8001_exec_internal_task_abort(struct pm8001_hba_info *pm8001_ha, res = pm8001_tag_alloc(pm8001_ha, &ccb_tag); if (res) - return res; + goto ex_err; ccb = &pm8001_ha->ccb_info[ccb_tag]; ccb->device = pm8001_dev; ccb->ccb_tag = ccb_tag; -- 2.25.1