From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91439C43461 for ; Mon, 14 Sep 2020 20:33:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4C97B215A4 for ; Mon, 14 Sep 2020 20:33:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="fLq43tsj" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726098AbgINUdG (ORCPT ); Mon, 14 Sep 2020 16:33:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37716 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726195AbgINUcN (ORCPT ); Mon, 14 Sep 2020 16:32:13 -0400 Received: from mail-pj1-x1043.google.com (mail-pj1-x1043.google.com [IPv6:2607:f8b0:4864:20::1043]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 94E57C06174A for ; Mon, 14 Sep 2020 13:32:11 -0700 (PDT) Received: by mail-pj1-x1043.google.com with SMTP id u3so492948pjr.3 for ; Mon, 14 Sep 2020 13:32:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=MAegNs4VOwWv9UrQbG/3KsC+fif9tz3H9h+v9DTenlg=; b=fLq43tsj0idL5YeRKTDNHNUi+/bcp9W/YMHPxve4qth42qg71hfTUM5Xq3cazIdDrI NFB+4SH1S70GAC48b8DplcyZACd4EXVyXgXskD80RFmDCDa/3pUt9RLyrlu1vxpWwB4f i2X0eeheLlVij915s5y5BUr4hEXriYpLc1OPM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=MAegNs4VOwWv9UrQbG/3KsC+fif9tz3H9h+v9DTenlg=; b=Plyh0pq5/I0fDkD4bVHaKoXQjgnZi+O1W07URBilWrYtuuwoWjb6gtvBl9rYJnJ0sh Np73XJ4CnOAnAoSD76VQm9N8UY3AvNHRQ7AgfZIXU1puwKaIdWrssW5XFqdgjkQanowI 23yxPUqnwAGgXvZGRIYKEUnbep5m0yJ39hO5oz4GNxFdrKLFtwy0FU8D1q/sGAXjO1E/ dCF0F93fTdmbIFCB22P/r9z7k0ajOvE1m2DSe/7TJSqQP/IlOrcbS94E0rJkUTzbLJRo /PklwLOh/xxBtdRiTvFlbI9qn/DoNTAiBJ7RWQT1MJ5DQeFzutgG+wR9WO2ipyLx0LfY SG5A== X-Gm-Message-State: AOAM531PjOd/owPQhZEvO+RzioqHvYfYI/R1gRV5wJgeb152+mxHlH0P zHDqJYWs7XADMj6QWRZuODVifQ== X-Google-Smtp-Source: ABdhPJwLrAeD4ZMb7OCOucEtPSfmxZNEDPJonNkzAiZJUR7jlcfwd9QjlJseUiJhoAyO2uqhAGri2A== X-Received: by 2002:a17:90b:364c:: with SMTP id nh12mr972235pjb.182.1600115531070; Mon, 14 Sep 2020 13:32:11 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id j19sm11207357pfi.51.2020.09.14.13.32.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Sep 2020 13:32:10 -0700 (PDT) Date: Mon, 14 Sep 2020 13:32:09 -0700 From: Kees Cook To: Michael Ellerman Cc: linux-kernel@vger.kernel.org, Thadeu Lima de Souza Cascardo , Max Filippov , Christian Brauner , Andy Lutomirski , Will Drewry , linux-kselftest@vger.kernel.org, linux-mips@vger.kernel.org, linux-xtensa@linux-xtensa.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH 00/15] selftests/seccomp: Refactor change_syscall() Message-ID: <202009141321.366935EF52@keescook> References: <20200912110820.597135-1-keescook@chromium.org> <87wo0wpnah.fsf@mpe.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87wo0wpnah.fsf@mpe.ellerman.id.au> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 14, 2020 at 10:15:18PM +1000, Michael Ellerman wrote: > Kees Cook writes: > > Hi, > > > > This refactors the seccomp selftest macros used in change_syscall(), > > in an effort to remove special cases for mips, arm, arm64, and xtensa, > > which paves the way for powerpc fixes. > > > > I'm not entirely done testing, but all-arch build tests and x86_64 > > selftests pass. I'll be doing arm, arm64, and i386 selftests shortly, > > but I currently don't have an easy way to check xtensa, mips, nor > > powerpc. Any help there would be appreciated! > > The series builds fine for me, and all the tests pass (see below). > > Thanks for picking up those changes to deal with powerpc being oddball. > > Tested-by: Michael Ellerman (powerpc) Awesome; thanks! However... > > cheers > > > ./seccomp_bpf > TAP version 13 > 1..86 > # Starting 86 tests from 7 test cases. > # RUN global.kcmp ... > # OK global.kcmp > ok 1 global.kcmp > [...] > # RUN global.KILL_thread ... > TAP version 13 > 1..86 > # Starting 86 tests from 7 test cases. Was this a mis-paste, or has something very very bad happened here in global.KILL_one_arg_six finishes? > # RUN global.kcmp ... > # OK global.kcmp > ok 1 global.kcmp > [...] > # RUN global.user_notification_basic ... > TAP version 13 > 1..86 > # Starting 86 tests from 7 test cases. > [...] > # RUN global.user_notification_basic ... > TAP version 13 > 1..86 > # Starting 86 tests from 7 test cases. > [...] > # RUN global.user_notification_signal ... > TAP version 13 > 1..86 > # Starting 86 tests from 7 test cases. > [...] > # RUN global.user_notification_closed_listener ... > TAP version 13 > 1..86 > # Starting 86 tests from 7 test cases. > [...] > # RUN global.user_notification_child_pid_ns ... > TAP version 13 > 1..86 > # Starting 86 tests from 7 test cases. > [...] > # RUN global.user_notification_sibling_pid_ns ... > TAP version 13 > 1..86 > # Starting 86 tests from 7 test cases. > [...] > # RUN global.user_notification_sibling_pid_ns ... > TAP version 13 > 1..86 > # Starting 86 tests from 7 test cases. > [...] > # RUN global.user_notification_sibling_pid_ns ... > TAP version 13 > 1..86 > # Starting 86 tests from 7 test cases. > [...] > # RUN global.user_notification_fault_recv ... > TAP version 13 > 1..86 > # Starting 86 tests from 7 test cases. > [...] > # RUN global.user_notification_continue ... > TAP version 13 > 1..86 > # Starting 86 tests from 7 test cases. > [...] > # RUN global.user_notification_filter_empty ... > TAP version 13 > 1..86 > # Starting 86 tests from 7 test cases. > [...] > # RUN global.user_notification_filter_empty_threaded ... > TAP version 13 > 1..86 > # Starting 86 tests from 7 test cases. > [...] > # RUN global.user_notification_addfd ... > TAP version 13 > 1..86 > # Starting 86 tests from 7 test cases. > [...] > # RUN global.user_notification_addfd_rlimit ... > TAP version 13 > 1..86 > # Starting 86 tests from 7 test cases. > [...] > # PASSED: 86 / 86 tests passed. > # Totals: pass:86 fail:0 xfail:0 xpass:0 skip:0 error:0 And after every user_notification test? O_O -- Kees Cook