Re: [PATCH v6 04/12] KVM: SVM: Modify intercept_exceptions to generic intercepts

Sean Christopherson
2020-09-14T15:07:39Z

On Sat, Sep 12, 2020 at 06:52:20PM +0200, Paolo Bonzini wrote:
> On 11/09/20 21:28, Babu Moger wrote:
> > diff --git a/arch/x86/kvm/svm/svm.c b/arch/x86/kvm/svm/svm.c
> > index 1a5f3908b388..11892e86cb39 100644
> > --- a/arch/x86/kvm/svm/svm.c
> > +++ b/arch/x86/kvm/svm/svm.c
> > @@ -1003,11 +1003,11 @@ static void init_vmcb(struct vcpu_svm *svm)
> >
> > set_dr_intercepts(svm);
> >
> > - set_exception_intercept(svm, PF_VECTOR);
> > - set_exception_intercept(svm, UD_VECTOR);
> > - set_exception_intercept(svm, MC_VECTOR);
> > - set_exception_intercept(svm, AC_VECTOR);
> > - set_exception_intercept(svm, DB_VECTOR);
> > + set_exception_intercept(svm, INTERCEPT_PF_VECTOR);
> > + set_exception_intercept(svm, INTERCEPT_UD_VECTOR);
> > + set_exception_intercept(svm, INTERCEPT_MC_VECTOR);
> > + set_exception_intercept(svm, INTERCEPT_AC_VECTOR);
> > + set_exception_intercept(svm, INTERCEPT_DB_VECTOR);
>
> I think these should take a vector instead, and add 64 in the functions.

And "s/int bit/u32 vector" + BUILD_BUG_ON(vector > 32)?