From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4342C433E2 for ; Mon, 14 Sep 2020 16:00:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6BCF721974 for ; Mon, 14 Sep 2020 16:00:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20150623.gappssmtp.com header.i=@bgdev-pl.20150623.gappssmtp.com header.b="rAMF2Tjx" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726547AbgINQAo (ORCPT ); Mon, 14 Sep 2020 12:00:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49948 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726519AbgINPqb (ORCPT ); Mon, 14 Sep 2020 11:46:31 -0400 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A8C2FC061220 for ; Mon, 14 Sep 2020 08:46:12 -0700 (PDT) Received: by mail-wm1-x341.google.com with SMTP id d4so486396wmd.5 for ; Mon, 14 Sep 2020 08:46:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=dZxSmrYbaeMpZke8aTud2a7+NtoqExH3ux3lqAPkyJY=; b=rAMF2TjxpBJIoU7kYaDU+icaC5IeQQwOQ5XHKvgZF0r9czxEwV6F/wSKOF8fskvj9L mlOQz+g+CPu7MjpDonN+Px4GTc4l3HKLhkmtkKO+bcrETWlCod2gyhgrwI95uBX7c1Rz B6w5ju9n/qds9XwuWncvf22sG+2c8PA45zcWp7aUl2hmJEzduOej4A/GTJ1SCZQSobgl NoweGZlrXbxFO4BpqU8FJtkKIx3KxKO7vbeGAl+Jl0jNymr3lCmv1LL6WR0m6lgYgV2X QWydK90cKYinntlqqRL6wlbQDnbXIlGZZWsdhUFeGbehJ52+kKWLs7QSxOBIcFniS2eo dr/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=dZxSmrYbaeMpZke8aTud2a7+NtoqExH3ux3lqAPkyJY=; b=M2l3Wn8dL+9zxc1BsQhXSFbpp2LYstIzwra9mvbHt+miAvQWCI6JRztVNg9WOFEs8z Omopf1zoaeSnxy1Sj4bEhG+CMadAo5M5/cHxoXyrqdxO20DJr2nZKRTciEHOAPC0AT5M CZ7vzRgTRbzQfofBXyDKNwL5tAUzFSsKzg5OfEGKdnssEI7cQXEDOY+pFw+50DcrzuZ1 nj8Tn0WvmtuDYa8ZXoEPQSlCRw7vi7x9JQ7dOKijSlF+dQPHwYBbjaSl/zzy6d1IABfz IV66nrjAo48ZmkQ+tE33Vzd40T57RKWUfrUgfGZH5MPV3ZNdrqZibK+JhYqIM+KkWyF7 WMKQ== X-Gm-Message-State: AOAM530FGqFMlhvc1jkwOB8GF943BI7aDjrWwJ7waWvutsvWy+Iqj5Bf BdFYJofzXBpMtRliJG/30okKQw== X-Google-Smtp-Source: ABdhPJyxI9z9y1wOPKAmsQvoxoaW/k8ouSEm71r187J1QGCrBr+P9qK1muhme2XC1UygjJqzK6OoRQ== X-Received: by 2002:a1c:67d4:: with SMTP id b203mr33404wmc.120.1600098371007; Mon, 14 Sep 2020 08:46:11 -0700 (PDT) Received: from debian-brgl.home (lfbn-nic-1-68-20.w2-15.abo.wanadoo.fr. [2.15.159.20]) by smtp.gmail.com with ESMTPSA id l19sm19510448wmi.8.2020.09.14.08.46.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Sep 2020 08:46:10 -0700 (PDT) From: Bartosz Golaszewski To: Alessandro Zummo , Alexandre Belloni Cc: linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski Subject: [PATCH v3 07/14] rtc: rx8010: don't use magic values for time buffer length Date: Mon, 14 Sep 2020 17:45:54 +0200 Message-Id: <20200914154601.32245-8-brgl@bgdev.pl> X-Mailer: git-send-email 2.26.1 In-Reply-To: <20200914154601.32245-1-brgl@bgdev.pl> References: <20200914154601.32245-1-brgl@bgdev.pl> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Bartosz Golaszewski The time buffer len is used directly in this driver. For readability it's better to define it as the difference between the date register offsets and use sizeof() whenever referencing it. Signed-off-by: Bartosz Golaszewski --- drivers/rtc/rtc-rx8010.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/rtc/rtc-rx8010.c b/drivers/rtc/rtc-rx8010.c index 300314ab7b6d..2c894e7aab6d 100644 --- a/drivers/rtc/rtc-rx8010.c +++ b/drivers/rtc/rtc-rx8010.c @@ -108,7 +108,7 @@ static irqreturn_t rx8010_irq_1_handler(int irq, void *dev_id) static int rx8010_get_time(struct device *dev, struct rtc_time *dt) { struct rx8010_data *rx8010 = dev_get_drvdata(dev); - u8 date[7]; + u8 date[RX8010_YEAR - RX8010_SEC + 1]; int flagreg, err; flagreg = i2c_smbus_read_byte_data(rx8010->client, RX8010_FLAG); @@ -121,8 +121,8 @@ static int rx8010_get_time(struct device *dev, struct rtc_time *dt) } err = i2c_smbus_read_i2c_block_data(rx8010->client, RX8010_SEC, - 7, date); - if (err != 7) + sizeof(date), date); + if (err != sizeof(date)) return err < 0 ? err : -EIO; dt->tm_sec = bcd2bin(date[RX8010_SEC - RX8010_SEC] & 0x7f); @@ -139,7 +139,7 @@ static int rx8010_get_time(struct device *dev, struct rtc_time *dt) static int rx8010_set_time(struct device *dev, struct rtc_time *dt) { struct rx8010_data *rx8010 = dev_get_drvdata(dev); - u8 date[7]; + u8 date[RX8010_YEAR - RX8010_SEC + 1]; int ctrl, flagreg, err; if ((dt->tm_year < 100) || (dt->tm_year > 199)) @@ -164,7 +164,8 @@ static int rx8010_set_time(struct device *dev, struct rtc_time *dt) date[RX8010_WDAY - RX8010_SEC] = bin2bcd(1 << dt->tm_wday); err = i2c_smbus_write_i2c_block_data(rx8010->client, - RX8010_SEC, 7, date); + RX8010_SEC, sizeof(date), + date); if (err < 0) return err; -- 2.26.1