From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5AC18C43461 for ; Mon, 14 Sep 2020 14:15:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 175A32076C for ; Mon, 14 Sep 2020 14:15:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600092945; bh=I5Q0Sc0ArcFSWCiqBhVtOYBqBwGBdQJZ2+JxwnWdPu0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=JlGzt2atUXDzz6soNpiHBPhYN/VXVZh+NlT9b2aJSew7j2bD9HU+vbHQ1gtN8Tnpl sFz4198Q/054oOnDhncSgL1lmOI4M7rdq+n6z2/Q5loRaRgIL1H+sJW1dYBMnk0l8q zrN/qW1jgA7M54Vfecl6QYw8oyu6J6Gac/LoDPmw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726239AbgINOPm (ORCPT ); Mon, 14 Sep 2020 10:15:42 -0400 Received: from mail.kernel.org ([198.145.29.99]:37530 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726818AbgINOOJ (ORCPT ); Mon, 14 Sep 2020 10:14:09 -0400 Received: from coco.lan (ip5f5ad5d8.dynamic.kabel-deutschland.de [95.90.213.216]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7E16D20EDD; Mon, 14 Sep 2020 14:13:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600092817; bh=I5Q0Sc0ArcFSWCiqBhVtOYBqBwGBdQJZ2+JxwnWdPu0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=M2yl01g87iv19UGAdn4Upjcxf8rR5Nr9IcAatVzWgXbE3Ey/89Lpw7rAIwUvHyR45 l89MvnmNReNQHbVKj0fRb3Y9XDC4sAh836l4AKKyfHMPeqeg10BiXpQYIIWz28T9R4 5C1M/k3xtS9udIFl335N2gYZEa82JsfGJJpLMwGk= Date: Mon, 14 Sep 2020 16:13:32 +0200 From: Mauro Carvalho Chehab To: Colin King Cc: John Stultz , Arnd Bergmann , Greg Kroah-Hartman , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][next] misc: hisi_hikey_usb: fix return of uninitialized ret status variable Message-ID: <20200914161332.2796e7b1@coco.lan> In-Reply-To: <20200914135646.99334-1-colin.king@canonical.com> References: <20200914135646.99334-1-colin.king@canonical.com> X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Mon, 14 Sep 2020 14:56:46 +0100 Colin King escreveu: > From: Colin Ian King > > Currently the return value from ret is uninitialized so the function > hisi_hikey_usb_parse_kirin970 is returning a garbage value when > succeeding. Since ret is not used anywhere else in the function, remove > it and just return 0 success at the end of the function. > > Addresses-Coverity: ("Uninitialixed scalar variable") > Fixes: d210a0023590 ("misc: hisi_hikey_usb: add support for Hikey 970") > Signed-off-by: Colin Ian King Reviewed-by: Mauro Carvalho Chehab > --- > drivers/misc/hisi_hikey_usb.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/misc/hisi_hikey_usb.c b/drivers/misc/hisi_hikey_usb.c > index 2ddd4072788d..5759e7209023 100644 > --- a/drivers/misc/hisi_hikey_usb.c > +++ b/drivers/misc/hisi_hikey_usb.c > @@ -151,7 +151,6 @@ static int hisi_hikey_usb_parse_kirin970(struct platform_device *pdev, > struct hisi_hikey_usb *hisi_hikey_usb) > { > struct regulator *regulator; > - int ret; > > regulator = devm_regulator_get(&pdev->dev, "hub-vdd"); > if (IS_ERR(regulator)) { > @@ -172,7 +171,7 @@ static int hisi_hikey_usb_parse_kirin970(struct platform_device *pdev, > if (IS_ERR(hisi_hikey_usb->reset)) > return PTR_ERR(hisi_hikey_usb->reset); > > - return ret; > + return 0; > } > > static int hisi_hikey_usb_probe(struct platform_device *pdev) Thanks, Mauro