Re: [RFC PATCH] USB: misc: Add usb_hub_pwr driver

Greg Kroah-Hartman
2020-09-02T06:07:49Z

On Tue, Sep 01, 2020 at 01:21:43PM -0700, Matthias Kaehlcke wrote:
> diff --git a/drivers/usb/misc/Makefile b/drivers/usb/misc/Makefile
> index da39bddb0604..2bd02388ca62 100644
> --- a/drivers/usb/misc/Makefile
> +++ b/drivers/usb/misc/Makefile
> @@ -31,3 +31,4 @@ obj-$(CONFIG_USB_CHAOSKEY) += chaoskey.o
>
> obj-$(CONFIG_USB_SISUSBVGA) += sisusbvga/
> obj-$(CONFIG_USB_LINK_LAYER_TEST) += lvstest.o
> +obj-$(CONFIG_USB_HUB_PWR) += usb_hub_pwr.o usb_hub_psupply.o

Why is this 2 files? Why can't it just be one?

And isn't this much the same thing as many of the other "misc" hub
controller drivers we have?

And to make it easier to review, can you split out the device tree
descriptions so that the DT maintainers can review that?

thanks,

greg k-h