From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Henry Burns <henrywolfeburns@gmail.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
Kim Phillips <kim.phillips@amd.com>,
Vijay Thakkar <vijaythakkar@me.com>,
Andi Kleen <ak@linux.intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf vendor events amd: remove trailing comma
Date: Mon, 14 Sep 2020 19:37:16 -0300 [thread overview]
Message-ID: <20200914223716.GK166601@kernel.org> (raw)
In-Reply-To: <20200912041101.2123-1-henrywolfeburns@gmail.com>
Em Sat, Sep 12, 2020 at 12:10:56AM -0400, Henry Burns escreveu:
> amdzen2/core.json had a trailing comma on the x_ret_fus_brnch_inst
> event. Since that goes against the JSON standard, lets remove it.
is this the only case in all the .json files we have in
tools/perf/pmu-events/?
- Arnaldo
> Signed-off-by: Henry Burns <henrywolfeburns@gmail.com>
> ---
> tools/perf/pmu-events/arch/x86/amdzen2/core.json | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/pmu-events/arch/x86/amdzen2/core.json b/tools/perf/pmu-events/arch/x86/amdzen2/core.json
> index de89e5a44ff1..4b75183da94a 100644
> --- a/tools/perf/pmu-events/arch/x86/amdzen2/core.json
> +++ b/tools/perf/pmu-events/arch/x86/amdzen2/core.json
> @@ -125,6 +125,6 @@
> {
> "EventName": "ex_ret_fus_brnch_inst",
> "EventCode": "0x1d0",
> - "BriefDescription": "Retired Fused Instructions. The number of fuse-branch instructions retired per cycle. The number of events logged per cycle can vary from 0-8.",
> + "BriefDescription": "Retired Fused Instructions. The number of fuse-branch instructions retired per cycle. The number of events logged per cycle can vary from 0-8."
> }
> ]
> --
> 2.25.1
>
--
- Arnaldo
next prev parent reply other threads:[~2020-09-14 22:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-12 4:10 [PATCH] perf vendor events amd: remove trailing comma Henry Burns
2020-09-14 22:37 ` Arnaldo Carvalho de Melo [this message]
2020-09-15 0:33 ` Henry Burns
2020-09-15 0:40 ` [PATCH v2] perf vendor events amd: remove trailing commas Henry Burns
2020-09-15 2:49 ` Namhyung Kim
2020-09-15 3:06 ` Kim Phillips
2020-09-15 11:55 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200914223716.GK166601@kernel.org \
--to=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=henrywolfeburns@gmail.com \
--cc=jolsa@redhat.com \
--cc=kim.phillips@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=vijaythakkar@me.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox