From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 959ADC43461 for ; Tue, 15 Sep 2020 00:18:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5A308208DB for ; Tue, 15 Sep 2020 00:18:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CiM5tvdC" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726102AbgIOASz (ORCPT ); Mon, 14 Sep 2020 20:18:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44452 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726043AbgIOASm (ORCPT ); Mon, 14 Sep 2020 20:18:42 -0400 Received: from mail-io1-xd42.google.com (mail-io1-xd42.google.com [IPv6:2607:f8b0:4864:20::d42]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B74D1C06174A for ; Mon, 14 Sep 2020 17:18:42 -0700 (PDT) Received: by mail-io1-xd42.google.com with SMTP id r25so2203171ioj.0 for ; Mon, 14 Sep 2020 17:18:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=MVXFq86Wzjq/2JiJKgUy5nszyPP/+FNZubjrZtz+U0E=; b=CiM5tvdCNkr0lm6UjCHD4rwh1bsdj1Z2cmrZ42EMj7BgLAg4dJTnRvapCjD+QP4nbo u0f277kQ1FudohbdLVuySFkP+AuXgs4G5PDVXkV6MVdadFlK3cQMg2cjVRsI+4ylMkDG ITYdnUrpjxmrADi5urho9PCP2Yh17TZXSN+dpy88jzkAA4Q86Z9FY46NZP+ACdh1VYQz +NoPYf5mDUcP5NqbO/Df3xzqtXxDXA0MTWVOGqFP01CvPRZvYNmk7mtTKnnHpm2Z0zZF jlQdjYwdmiWKgyMoT8wZSRDCaYIQAEJzSufWoqCA1Sg/xqTFTNNr+hulYLsLB/xfONxD +SkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=MVXFq86Wzjq/2JiJKgUy5nszyPP/+FNZubjrZtz+U0E=; b=TZUQ2IPosRvdIpOV+yu5ctY+e5j6Jk9BBogar340ajehyoTsF52Dk4IAYP+IE1Kc0/ RJkXy9V2AyGcKhe/9V2CiX84zNYfxH4/7yRSYwlmDmwbdv1p7IVFDcI6421FNeH/3Fa3 mxErVcT+hkEVKOxZADKX5SXso/VIrDvitv2og+M7Sgsy0vvzIPb84FjiMz44T1J5MNsD ke+Bu6OuniOgvZaW0cvLNYSL98XHY0liZVUe1K/EDVsBl5XqVVZH7r1TSKHNiNRvT8IQ hyS+8YFrqPxFVT/DOqYjvO2HnDiAH/blWnHymJMKb1Uz8tR8FrQB1aS9a9yS2Ynz6q+j X6NQ== X-Gm-Message-State: AOAM532rigUFUurwFS8wP2lZ+J0tyi8HTF5cmD5rD7hWbxvrKb2cwDpQ oKPnML8Fw4t6eRUIhbv9IMw= X-Google-Smtp-Source: ABdhPJxuXc88y9/0sq8TNKqREs2kXFcAs2Xcnn82Xd+G37iawrl8PvEdH7vF+UakPDUyyT6ItiXXJA== X-Received: by 2002:a5e:9809:: with SMTP id s9mr13458565ioj.171.1600129122054; Mon, 14 Sep 2020 17:18:42 -0700 (PDT) Received: from localhost.localdomain (c-73-242-81-227.hsd1.mn.comcast.net. [73.242.81.227]) by smtp.gmail.com with ESMTPSA id l131sm6728975ioa.31.2020.09.14.17.18.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Sep 2020 17:18:41 -0700 (PDT) From: Ross Schmidt To: gregkh@linuxfoundation.org Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Ross Schmidt Subject: [PATCH 2/3] staging: rtl8723bs: os_dep: fixed bracing issue Date: Mon, 14 Sep 2020 19:17:30 -0500 Message-Id: <20200915001731.28986-2-ross.schm.dev@gmail.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200915001731.28986-1-ross.schm.dev@gmail.com> References: <20200915001731.28986-1-ross.schm.dev@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fixed a coding style issue by removing unnecessary braces in sdio_ops_linux.c to fix checkpatch warnings. Signed-off-by: Ross Schmidt --- drivers/staging/rtl8723bs/os_dep/sdio_ops_linux.c | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/sdio_ops_linux.c b/drivers/staging/rtl8723bs/os_dep/sdio_ops_linux.c index bc8cef5589b8..87fc87662075 100644 --- a/drivers/staging/rtl8723bs/os_dep/sdio_ops_linux.c +++ b/drivers/staging/rtl8723bs/os_dep/sdio_ops_linux.c @@ -275,9 +275,8 @@ u32 sd_read32(struct intf_hdl *pintfhdl, u32 addr, s32 *err) break; } else { DBG_871X(KERN_ERR "%s: (%d) addr = 0x%05x, val = 0x%x, try_cnt =%d\n", __func__, *err, addr, v, i); - if ((-ESHUTDOWN == *err) || (-ENODEV == *err)) { + if ((-ESHUTDOWN == *err) || (-ENODEV == *err)) padapter->bSurpriseRemoved = true; - } if (rtw_inc_and_chk_continual_io_error(psdiodev) == true) { padapter->bSurpriseRemoved = true; @@ -367,9 +366,8 @@ void sd_write32(struct intf_hdl *pintfhdl, u32 addr, u32 v, s32 *err) break; } else { DBG_871X(KERN_ERR "%s: (%d) addr = 0x%05x, val = 0x%x, try_cnt =%d\n", __func__, *err, addr, v, i); - if ((-ESHUTDOWN == *err) || (-ENODEV == *err)) { + if ((-ESHUTDOWN == *err) || (-ENODEV == *err)) padapter->bSurpriseRemoved = true; - } if (rtw_inc_and_chk_continual_io_error(psdiodev) == true) { padapter->bSurpriseRemoved = true; @@ -436,9 +434,9 @@ s32 _sd_read(struct intf_hdl *pintfhdl, u32 addr, u32 cnt, void *pdata) } err = sdio_memcpy_fromio(func, pdata, addr, cnt); - if (err) { + if (err) DBG_871X(KERN_ERR "%s: FAIL(%d)! ADDR =%#x Size =%d\n", __func__, err, addr, cnt); - } + return err; } @@ -538,9 +536,9 @@ s32 _sd_write(struct intf_hdl *pintfhdl, u32 addr, u32 cnt, void *pdata) size = cnt; err = sdio_memcpy_toio(func, addr, pdata, size); - if (err) { + if (err) DBG_871X(KERN_ERR "%s: FAIL(%d)! ADDR =%#x Size =%d(%d)\n", __func__, err, addr, cnt, size); - } + return err; } -- 2.26.2