[PATCH RESEND RESEND] remoteproc: scp: add COMPILE_TEST dependency

[PATCH RESEND RESEND] remoteproc: scp: add COMPILE_TEST dependency

[Alexandre Courbot]

This will improve this driver's build coverage.

Reported-by: Ezequiel Garcia <ezequiel@collabora.com>
Signed-off-by: Alexandre Courbot <acourbot@chromium.org>
---
Hi remoteproc maintainers,

Second resend as I got no reaction for almost 1 month on this one-liner.
Pretty please?

As explained in
https://www.spinics.net/lists/linux-media/msg175991.html, we need this
patch in order to merge a driver series in the media tree. If that
looks ok to you, can we pull it in the media tree along with the series
that depends on it?

 drivers/remoteproc/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/remoteproc/Kconfig b/drivers/remoteproc/Kconfig
index c6659dfea7c7..d1fcada71017 100644
--- a/drivers/remoteproc/Kconfig
+++ b/drivers/remoteproc/Kconfig
@@ -43,7 +43,7 @@ config INGENIC_VPU_RPROC
 
 config MTK_SCP
 	tristate "Mediatek SCP support"
-	depends on ARCH_MEDIATEK
+	depends on ARCH_MEDIATEK || COMPILE_TEST
 	select RPMSG_MTK_SCP
 	help
 	  Say y here to support Mediatek's System Companion Processor (SCP) via
-- 
2.28.0.526.ge36021eeef-goog

Re: [PATCH RESEND RESEND] remoteproc: scp: add COMPILE_TEST dependency

[Bjorn Andersson]

On Tue 15 Sep 01:29 UTC 2020, Alexandre Courbot wrote:

> This will improve this driver's build coverage.
> 
> Reported-by: Ezequiel Garcia <ezequiel@collabora.com>
> Signed-off-by: Alexandre Courbot <acourbot@chromium.org>
> ---
> Hi remoteproc maintainers,
> 
> Second resend as I got no reaction for almost 1 month on this one-liner.

Sorry about that. I fell behind on my inbox and have missed your
previous attempts.

This has now been applied.

Regards,
Bjorn

> Pretty please?
> 
> As explained in
> https://www.spinics.net/lists/linux-media/msg175991.html, we need this
> patch in order to merge a driver series in the media tree. If that
> looks ok to you, can we pull it in the media tree along with the series
> that depends on it?
> 
>  drivers/remoteproc/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/remoteproc/Kconfig b/drivers/remoteproc/Kconfig
> index c6659dfea7c7..d1fcada71017 100644
> --- a/drivers/remoteproc/Kconfig
> +++ b/drivers/remoteproc/Kconfig
> @@ -43,7 +43,7 @@ config INGENIC_VPU_RPROC
>  
>  config MTK_SCP
>  	tristate "Mediatek SCP support"
> -	depends on ARCH_MEDIATEK
> +	depends on ARCH_MEDIATEK || COMPILE_TEST
>  	select RPMSG_MTK_SCP
>  	help
>  	  Say y here to support Mediatek's System Companion Processor (SCP) via
> -- 
> 2.28.0.526.ge36021eeef-goog
> 

Re: [PATCH RESEND RESEND] remoteproc: scp: add COMPILE_TEST dependency

[Alexandre Courbot]

On Tue, Sep 15, 2020 at 12:25 PM Bjorn Andersson
<bjorn.andersson@linaro.org> wrote:
>
> On Tue 15 Sep 01:29 UTC 2020, Alexandre Courbot wrote:
>
> > This will improve this driver's build coverage.
> >
> > Reported-by: Ezequiel Garcia <ezequiel@collabora.com>
> > Signed-off-by: Alexandre Courbot <acourbot@chromium.org>
> > ---
> > Hi remoteproc maintainers,
> >
> > Second resend as I got no reaction for almost 1 month on this one-liner.
>
> Sorry about that. I fell behind on my inbox and have missed your
> previous attempts.
>
> This has now been applied.

No worries, thanks for the quick response.

Mauro, the patch is applied on
https://git.kernel.org/pub/scm/linux/kernel/git/andersson/remoteproc.git/commit/?id=5185e3a9dc2d68bb52e3e12400428aa060b87733,
will it work for you to merge this into the media tree and apply the
pull request on top?

>
> Regards,
> Bjorn
>
> > Pretty please?
> >
> > As explained in
> > https://www.spinics.net/lists/linux-media/msg175991.html, we need this
> > patch in order to merge a driver series in the media tree. If that
> > looks ok to you, can we pull it in the media tree along with the series
> > that depends on it?
> >
> >  drivers/remoteproc/Kconfig | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/remoteproc/Kconfig b/drivers/remoteproc/Kconfig
> > index c6659dfea7c7..d1fcada71017 100644
> > --- a/drivers/remoteproc/Kconfig
> > +++ b/drivers/remoteproc/Kconfig
> > @@ -43,7 +43,7 @@ config INGENIC_VPU_RPROC
> >
> >  config MTK_SCP
> >       tristate "Mediatek SCP support"
> > -     depends on ARCH_MEDIATEK
> > +     depends on ARCH_MEDIATEK || COMPILE_TEST
> >       select RPMSG_MTK_SCP
> >       help
> >         Say y here to support Mediatek's System Companion Processor (SCP) via
> > --
> > 2.28.0.526.ge36021eeef-goog
> >

Re: [PATCH RESEND RESEND] remoteproc: scp: add COMPILE_TEST dependency

[Mauro Carvalho Chehab]

Em Tue, 15 Sep 2020 12:43:26 +0900
Alexandre Courbot <acourbot@chromium.org> escreveu:

> On Tue, Sep 15, 2020 at 12:25 PM Bjorn Andersson
> <bjorn.andersson@linaro.org> wrote:
> >
> > On Tue 15 Sep 01:29 UTC 2020, Alexandre Courbot wrote:
> >  
> > > This will improve this driver's build coverage.
> > >
> > > Reported-by: Ezequiel Garcia <ezequiel@collabora.com>
> > > Signed-off-by: Alexandre Courbot <acourbot@chromium.org>
> > > ---
> > > Hi remoteproc maintainers,
> > >
> > > Second resend as I got no reaction for almost 1 month on this one-liner.  
> >
> > Sorry about that. I fell behind on my inbox and have missed your
> > previous attempts.
> >
> > This has now been applied.  
> 
> No worries, thanks for the quick response.
> 
> Mauro, the patch is applied on
> https://git.kernel.org/pub/scm/linux/kernel/git/andersson/remoteproc.git/commit/?id=5185e3a9dc2d68bb52e3e12400428aa060b87733,
> will it work for you to merge this into the media tree and apply the
> pull request on top?
> 
> >
> > Regards,
> > Bjorn
> >  
> > > Pretty please?
> > >
> > > As explained in
> > > https://www.spinics.net/lists/linux-media/msg175991.html, we need this
> > > patch in order to merge a driver series in the media tree. If that
> > > looks ok to you, can we pull it in the media tree along with the series
> > > that depends on it?
> > >
> > >  drivers/remoteproc/Kconfig | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/remoteproc/Kconfig b/drivers/remoteproc/Kconfig
> > > index c6659dfea7c7..d1fcada71017 100644
> > > --- a/drivers/remoteproc/Kconfig
> > > +++ b/drivers/remoteproc/Kconfig
> > > @@ -43,7 +43,7 @@ config INGENIC_VPU_RPROC
> > >
> > >  config MTK_SCP
> > >       tristate "Mediatek SCP support"
> > > -     depends on ARCH_MEDIATEK
> > > +     depends on ARCH_MEDIATEK || COMPILE_TEST
> > >       select RPMSG_MTK_SCP
> > >       help
> > >         Say y here to support Mediatek's System Companion Processor (SCP) via

Bjorn/Alexandre,

Can I just cherry-pick the patch from:

	https://git.kernel.org/pub/scm/linux/kernel/git/andersson/remoteproc.git/commit/?id=5185e3a9dc2d68bb52e3e12400428aa060b87733

Adding it on my tree before the patches that require it?

If aren't there any other changes for "config MTK_SCP",
this is the easiest way for me, as I won't need to pull from
a stable branch from your tree and wait for your patches to
reach upstream, before sending a tree branch with such changes.

Regards,
Mauro

Re: [PATCH RESEND RESEND] remoteproc: scp: add COMPILE_TEST dependency

[Bjorn Andersson]

On Thu 17 Sep 07:13 CDT 2020, Mauro Carvalho Chehab wrote:

> Em Tue, 15 Sep 2020 12:43:26 +0900
> Alexandre Courbot <acourbot@chromium.org> escreveu:
> 
> > On Tue, Sep 15, 2020 at 12:25 PM Bjorn Andersson
> > <bjorn.andersson@linaro.org> wrote:
> > >
> > > On Tue 15 Sep 01:29 UTC 2020, Alexandre Courbot wrote:
> > >  
> > > > This will improve this driver's build coverage.
> > > >
> > > > Reported-by: Ezequiel Garcia <ezequiel@collabora.com>
> > > > Signed-off-by: Alexandre Courbot <acourbot@chromium.org>
> > > > ---
> > > > Hi remoteproc maintainers,
> > > >
> > > > Second resend as I got no reaction for almost 1 month on this one-liner.  
> > >
> > > Sorry about that. I fell behind on my inbox and have missed your
> > > previous attempts.
> > >
> > > This has now been applied.  
> > 
> > No worries, thanks for the quick response.
> > 
> > Mauro, the patch is applied on
> > https://git.kernel.org/pub/scm/linux/kernel/git/andersson/remoteproc.git/commit/?id=5185e3a9dc2d68bb52e3e12400428aa060b87733,
> > will it work for you to merge this into the media tree and apply the
> > pull request on top?
> > 
> > >
> > > Regards,
> > > Bjorn
> > >  
> > > > Pretty please?
> > > >
> > > > As explained in
> > > > https://www.spinics.net/lists/linux-media/msg175991.html, we need this
> > > > patch in order to merge a driver series in the media tree. If that
> > > > looks ok to you, can we pull it in the media tree along with the series
> > > > that depends on it?
> > > >
> > > >  drivers/remoteproc/Kconfig | 2 +-
> > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/drivers/remoteproc/Kconfig b/drivers/remoteproc/Kconfig
> > > > index c6659dfea7c7..d1fcada71017 100644
> > > > --- a/drivers/remoteproc/Kconfig
> > > > +++ b/drivers/remoteproc/Kconfig
> > > > @@ -43,7 +43,7 @@ config INGENIC_VPU_RPROC
> > > >
> > > >  config MTK_SCP
> > > >       tristate "Mediatek SCP support"
> > > > -     depends on ARCH_MEDIATEK
> > > > +     depends on ARCH_MEDIATEK || COMPILE_TEST
> > > >       select RPMSG_MTK_SCP
> > > >       help
> > > >         Say y here to support Mediatek's System Companion Processor (SCP) via
> 
> Bjorn/Alexandre,
> 
> Can I just cherry-pick the patch from:
> 
> 	https://git.kernel.org/pub/scm/linux/kernel/git/andersson/remoteproc.git/commit/?id=5185e3a9dc2d68bb52e3e12400428aa060b87733
> 
> Adding it on my tree before the patches that require it?
> 
> If aren't there any other changes for "config MTK_SCP",
> this is the easiest way for me, as I won't need to pull from
> a stable branch from your tree and wait for your patches to
> reach upstream, before sending a tree branch with such changes.
> 

I don't see anything that would cause a merge conflicts here, so that
should be fine. And perhaps we should just have picked it through your
tree from the beginning then.

Feel free to add my:

Acked-by: Bjorn Andersson <bjorn.andersson@linaro.org>

Regards,
Bjorn