Re: [Linux-kernel-mentees] [PATCH] idr: remove WARN_ON_ONCE() when trying to check id

Anmol Karn
2020-09-14T18:48:22Z

On Mon, Sep 14, 2020 at 12:08:03PM +0100, Matthew Wilcox wrote:
> On Mon, Sep 14, 2020 at 12:47:24PM +0530, Anmol Karn wrote:
> > idr_get_next() gives WARN_ON_ONCE() when it gets (id > INT_MAX) true
> > and this happens when syzbot does fuzzing, and that warning is
> > expected, but WARN_ON_ONCE() is not required here and, cecking
> > the condition and returning NULL value would be suffice.
> >
> > Reference: commit b9959c7a347 ("filldir[64]: remove WARN_ON_ONCE() for bad directory entries")
> > Reported-and-tested-by: syzbot+f7204dcf3df4bb4ce42c@syzkaller.appspotmail.com
> > Link: https://syzkaller.appspot.com/bug?extid=f7204dcf3df4bb4ce42c
> > Signed-off-by: Anmol Karn <anmol.karan123@gmail.com>
>
> https://lore.kernel.org/netdev/20200605120037.17427-1-willy@infradead.org/

Hello sir,

I have looked into the patch, and it seems the problem is fixed to the root cause
in this patch, but not yet merged due to some backport issues, so, please ignore
this patch(sent by me), and please let me know if i can contribute to fixing this
bug's root cause.

Thanks,
Anmol