From: Eugen Hristev <eugen.hristev@microchip.com>
To: <sakari.ailus@iki.fi>, <luca@lucaceresoli.net>,
<leonl@leopardimaging.com>
Cc: <linux-media@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
"Eugen Hristev" <eugen.hristev@microchip.com>,
Sakari Ailus <sakari.ailus@ifi.fi>
Subject: [PATCH v2 1/2] media: imx274: remove binning enum
Date: Tue, 15 Sep 2020 12:04:41 +0300 [thread overview]
Message-ID: <20200915090442.52322-1-eugen.hristev@microchip.com> (raw)
Binning enum is unused. Remove from driver.
Suggested-by: Sakari Ailus <sakari.ailus@ifi.fi>
Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>
---
Changes in v2:
- new patch
drivers/media/i2c/imx274.c | 9 +--------
1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a/drivers/media/i2c/imx274.c b/drivers/media/i2c/imx274.c
index e6aa9f32b6a8..69221c2c192c 100644
--- a/drivers/media/i2c/imx274.c
+++ b/drivers/media/i2c/imx274.c
@@ -65,7 +65,6 @@
*/
#define IMX274_MIN_EXPOSURE_TIME (4 * 260 / 72)
-#define IMX274_DEFAULT_BINNING IMX274_BINNING_OFF
#define IMX274_MAX_WIDTH (3840)
#define IMX274_MAX_HEIGHT (2160)
#define IMX274_MAX_FRAME_RATE (120)
@@ -145,12 +144,6 @@ static const struct regmap_config imx274_regmap_config = {
.cache_type = REGCACHE_RBTREE,
};
-enum imx274_binning {
- IMX274_BINNING_OFF,
- IMX274_BINNING_2_1,
- IMX274_BINNING_3_1,
-};
-
/*
* Parameters for each imx274 readout mode.
*
@@ -1837,7 +1830,7 @@ static int imx274_probe(struct i2c_client *client)
mutex_init(&imx274->lock);
/* initialize format */
- imx274->mode = &imx274_modes[IMX274_DEFAULT_BINNING];
+ imx274->mode = &imx274_modes[0];
imx274->crop.width = IMX274_MAX_WIDTH;
imx274->crop.height = IMX274_MAX_HEIGHT;
imx274->format.width = imx274->crop.width / imx274->mode->bin_ratio;
--
2.25.1
next reply other threads:[~2020-09-15 9:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-15 9:04 Eugen Hristev [this message]
2020-09-15 9:04 ` [PATCH v2 2/2] media: imx274: add support for sensor mode6, 1280x540 Eugen Hristev
2020-09-15 9:25 ` Luca Ceresoli
2020-09-15 9:21 ` [PATCH v2 1/2] media: imx274: remove binning enum Luca Ceresoli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200915090442.52322-1-eugen.hristev@microchip.com \
--to=eugen.hristev@microchip.com \
--cc=leonl@leopardimaging.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=luca@lucaceresoli.net \
--cc=sakari.ailus@ifi.fi \
--cc=sakari.ailus@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox