Re: [PATCH 5.4 131/132] drm/msm: Enable expanded apriv support for a650

Greg Kroah-Hartman
2020-09-15T17:28:21Z

On Tue, Sep 15, 2020 at 10:03:19AM -0600, Jordan Crouse wrote:
> On Tue, Sep 15, 2020 at 04:13:53PM +0200, Greg Kroah-Hartman wrote:
> > From: Jordan Crouse <jcrouse@codeaurora.org>
> >
> > [ Upstream commit 604234f33658cdd72f686be405a99646b397d0b3 ]
> >
> > a650 supports expanded apriv support that allows us to map critical buffers
> > (ringbuffer and memstore) as as privileged to protect them from corruption.
> >
> > Cc: stable@vger.kernel.org
> > Signed-off-by: Jordan Crouse <jcrouse@codeaurora.org>
> > Signed-off-by: Rob Clark <robdclark@chromium.org>
> > Signed-off-by: Sasha Levin <sashal@kernel.org>
>
> Hi. A bug was reported in this patch with a fix just posted to the list [1].
> Since the RPTR shadow is being disabled universally by f6828e0c4045 ("drm/msm:
> Disable the RPTR shadow") that will address the security concern and we won't
> need the extra protection from this patch. I suggest that you drop it for the
> stable trees and we can merge the fix into 5.9 to re-enable APRIV for newer
> kernels.

Ok, thanks, now dropped from 5.8.y and 5.4.y trees.

greg k-h