From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EDBDBC43461 for ; Tue, 15 Sep 2020 23:51:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BA0442078D for ; Tue, 15 Sep 2020 23:51:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600213910; bh=pqkBCZbfXLAK3NI373fRnWPFNbYoVbdXIH8h5Xe3rZE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=yPeIj57Q3VPhn8EgWc0oExYd2WsTsnNOz12O793RDHRyEIXEcr7IGxzEY9aZs9YzH mMFpkPiGyM5hImxlzD9SSTp6TWb/969HBVBnvRIEZU4/6sbxo2167P29tm3Uaa7ebe PXYJ48UfOQ8Ti8J8gbv0XBuGV8MzudJt5dAWdWAc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727283AbgIOXvr (ORCPT ); Tue, 15 Sep 2020 19:51:47 -0400 Received: from mail.kernel.org ([198.145.29.99]:47654 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727087AbgIOOcm (ORCPT ); Tue, 15 Sep 2020 10:32:42 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3F89722C9E; Tue, 15 Sep 2020 14:24:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600179846; bh=pqkBCZbfXLAK3NI373fRnWPFNbYoVbdXIH8h5Xe3rZE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mKgCa5i80ltRy9bPMTcii6c4SWxAsqfEHm+lqEtilcwlYzeN+oWJwOp6g+pQZBft1 Bn7TO5DkYzkCzxJ7z7girisfaNBTr4Ok1CzXIsjwfb6z2iTkSdKd0dHtmsF1eJSBzp JMBJNP2yam9g/9e9ocFq9VSULJx/tsZPMm4jexQA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jing Xiangfeng , Tony Lindgren , Sasha Levin Subject: [PATCH 5.8 001/177] ARM: OMAP2+: Fix an IS_ERR() vs NULL check in _get_pwrdm() Date: Tue, 15 Sep 2020 16:11:12 +0200 Message-Id: <20200915140653.691038767@linuxfoundation.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200915140653.610388773@linuxfoundation.org> References: <20200915140653.610388773@linuxfoundation.org> User-Agent: quilt/0.66 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jing Xiangfeng [ Upstream commit a58cfdba2039ff2d5758840e97a23a2dedecf1e8 ] The of_clk_get() function returns error pointers, it never returns NULL. Fixes: 4ea3711aece4 ("ARM: OMAP2+: omap-iommu.c conversion to ti-sysc") Signed-off-by: Jing Xiangfeng Signed-off-by: Tony Lindgren Signed-off-by: Sasha Levin --- arch/arm/mach-omap2/omap-iommu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/mach-omap2/omap-iommu.c b/arch/arm/mach-omap2/omap-iommu.c index 54aff33e55e6e..bfa5e1b8dba7f 100644 --- a/arch/arm/mach-omap2/omap-iommu.c +++ b/arch/arm/mach-omap2/omap-iommu.c @@ -74,7 +74,7 @@ static struct powerdomain *_get_pwrdm(struct device *dev) return pwrdm; clk = of_clk_get(dev->of_node->parent, 0); - if (!clk) { + if (IS_ERR(clk)) { dev_err(dev, "no fck found\n"); return NULL; } -- 2.25.1