From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A53A2C43461 for ; Tue, 15 Sep 2020 23:03:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7533B206DC for ; Tue, 15 Sep 2020 23:03:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726825AbgIOXDY (ORCPT ); Tue, 15 Sep 2020 19:03:24 -0400 Received: from mx2.suse.de ([195.135.220.15]:60200 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727362AbgIOOzt (ORCPT ); Tue, 15 Sep 2020 10:55:49 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 44D92AC7D; Tue, 15 Sep 2020 14:55:50 +0000 (UTC) Date: Tue, 15 Sep 2020 16:55:33 +0200 From: Michal Hocko To: Chris Down Cc: zangchunxin@bytedance.com, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Muchun Song Subject: Re: [PATCH v4] mm/vmscan: add a fatal signals check in drop_slab_node Message-ID: <20200915145533.GG3736@dhcp22.suse.cz> References: <20200915132741.84869-1-zangchunxin@bytedance.com> <20200915144737.GA2581123@chrisdown.name> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200915144737.GA2581123@chrisdown.name> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue 15-09-20 15:47:37, Chris Down wrote: > zangchunxin@bytedance.com writes: > > + if (signal_pending(current)) > > + return; > > This doesn't match your patch title, please update it. :-) I have to admit I have completely missed this and I think that this should better be fatal_signal_pending because that would make sure that the userspace will not see an incomplete operation. This is a general practice for other bail outs as well. > After that, you can add: > > Acked-by: Chris Down -- Michal Hocko SUSE Labs