Re: [PATCH 5/6] scsi: ufs: show ufs part info in error case

Bean Huo
2020-09-16T11:05:57Z

On Tue, 2020-09-15 at 13:45 -0700, Jaegeuk Kim wrote:
> Cc: Avri Altman <avri.altman@wdc.com>
> Signed-off-by: Jaegeuk Kim <jaegeuk@google.com>
> ---
> drivers/scsi/ufs/ufshcd.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> index bdc82cc3824aa..b81c116b976ff 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -500,6 +500,14 @@ static void ufshcd_print_tmrs(struct ufs_hba
> *hba, unsigned long bitmap)
> static void ufshcd_print_host_state(struct ufs_hba *hba)
> {
> dev_err(hba->dev, "UFS Host state=%d\n", hba->ufshcd_state);
> + if (hba->sdev_ufs_device) {
> + dev_err(hba->dev, " vendor = %.8s\n",
> + hba->sdev_ufs_device-
> >vendor);
> + dev_err(hba->dev, " model = %.16s\n",
> + hba->sdev_ufs_device->model);
> + dev_err(hba->dev, " rev = %.4s\n",
> + hba->sdev_ufs_device->rev);
> + }

Hi Jaegeuk
these prints have been added since this change:

commit 3f8af6044713 ("scsi: ufs: Add some debug information to
ufshcd_print_host_state()")

https://patchwork.kernel.org/patch/11694371/

Thanks,
Bean