From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F094AC433E2 for ; Wed, 16 Sep 2020 01:34:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B00A820936 for ; Wed, 16 Sep 2020 01:34:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726355AbgIPBeH (ORCPT ); Tue, 15 Sep 2020 21:34:07 -0400 Received: from mga09.intel.com ([134.134.136.24]:49975 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726166AbgIPBeF (ORCPT ); Tue, 15 Sep 2020 21:34:05 -0400 IronPort-SDR: jYtZe6N2Jm47X6p20D133IfZkBgh5y0WZGFYTn2ZFB8Fiw/YH6jmR4xMjeNbo+vXu6PS3oK21I 83t1sqNLz6aA== X-IronPort-AV: E=McAfee;i="6000,8403,9745"; a="160314308" X-IronPort-AV: E=Sophos;i="5.76,430,1592895600"; d="scan'208";a="160314308" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Sep 2020 18:34:04 -0700 IronPort-SDR: zv+n+at9i1NMfj5WzjxhlFKQP0m5WZkDl+mQQDmbXfxuRVSAjFllsrO577hzDvlIUZr34oJHe6 odMogtaZD4aw== X-IronPort-AV: E=Sophos;i="5.76,430,1592895600"; d="scan'208";a="483090074" Received: from joy-optiplex-7040.sh.intel.com (HELO joy-OptiPlex-7040) ([10.239.13.16]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Sep 2020 18:34:02 -0700 Date: Wed, 16 Sep 2020 09:33:00 +0800 From: Yan Zhao To: Cornelia Huck Cc: alex.williamson@redhat.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] vfio: fix a missed vfio group put in vfio_pin_pages Message-ID: <20200916013259.GA18934@joy-OptiPlex-7040> Reply-To: Yan Zhao References: <20200915002835.14213-1-yan.y.zhao@intel.com> <20200915110601.5adb7129.cohuck@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200915110601.5adb7129.cohuck@redhat.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 15, 2020 at 11:06:01AM +0200, Cornelia Huck wrote: > On Tue, 15 Sep 2020 08:28:35 +0800 > Yan Zhao wrote: > > > when error occurs, need to put vfio group after a successful get. > > > > Fixes: 95fc87b44104 (vfio: Selective dirty page tracking if IOMMU backed > > device pins pages) > > The format of the Fixes: line should be > > Fixes: 95fc87b44104 ("vfio: Selective dirty page tracking if IOMMU backed device pins pages") > got it. thanks! I'll update it. Thanks Yan > > > > Signed-off-by: Yan Zhao > > --- > > drivers/vfio/vfio.c | 6 ++++-- > > 1 file changed, 4 insertions(+), 2 deletions(-) > > Reviewed-by: Cornelia Huck >